From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#71355: 30.0.50; [PATCH] Improve performance of buffered output in Eshell Date: Thu, 6 Jun 2024 11:04:57 -0700 Message-ID: <1b317092-4820-69c2-6e23-cbf48748b73c@gmail.com> References: <22b0dc8f-11dc-5fd2-c75d-88c17580d28d@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30602"; mail-complaints-to="usenet@ciao.gmane.io" To: Stefan Kangas , 71355@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 06 20:06:56 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sFHVn-0007q1-Qi for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Jun 2024 20:06:56 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sFHVh-0000oc-3h; Thu, 06 Jun 2024 14:06:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFHVg-0000oN-3J for bug-gnu-emacs@gnu.org; Thu, 06 Jun 2024 14:06:48 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sFHVf-0000Hf-Q1 for bug-gnu-emacs@gnu.org; Thu, 06 Jun 2024 14:06:47 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sFHVu-00081O-FY for bug-gnu-emacs@gnu.org; Thu, 06 Jun 2024 14:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Jun 2024 18:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71355 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71355-submit@debbugs.gnu.org id=B71355.171769718130734 (code B ref 71355); Thu, 06 Jun 2024 18:07:02 +0000 Original-Received: (at 71355) by debbugs.gnu.org; 6 Jun 2024 18:06:21 +0000 Original-Received: from localhost ([127.0.0.1]:59922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFHVE-0007zc-If for submit@debbugs.gnu.org; Thu, 06 Jun 2024 14:06:20 -0400 Original-Received: from mail-pl1-f174.google.com ([209.85.214.174]:45371) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFHVC-0007zI-Qy for 71355@debbugs.gnu.org; Thu, 06 Jun 2024 14:06:19 -0400 Original-Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1f44b5b9de6so11304325ad.3 for <71355@debbugs.gnu.org>; Thu, 06 Jun 2024 11:06:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717697098; x=1718301898; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=6TQASJHg98F901BqhTybLLk6VXk4jDBShOMrUWFyoW4=; b=Ndk9Y0u509GYnwLzN3CcHuMtaftY9DffQeUuBfdhwgRoZt182j1QJbZJw9JSzg//yS JdlS0d9xZLI2ygHgJJ2b5OBtSvahJxoSlxG3RsWZ3kBAK+ZPY/fIXkAvC6eExcmTUHFz XfoaY3boker70GG6hViUnAFstesosxhsN+27qcQz6svbTMEXnnArICzrD+kOf+GdaBb2 JTmJSmUbEe+eQaM/g3sP8F87MU/eAeQbOodLA5NI72zfBVfsBtryrSKvF6ddI6cGjx4Q ReLEgo7Xi8Yk68TY9xIuG32lmSWp8Nx7mzEiEHEC3t8fI3RNHpjnO1UmZIDqK3zNH4gv ka+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717697098; x=1718301898; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6TQASJHg98F901BqhTybLLk6VXk4jDBShOMrUWFyoW4=; b=mfdqpUYbBFObLEupj2LD7reirNSrWqMwa4Q5txd2byTzLzcf+HxYyuGlmv17/RmtII 0NKS96SQKgB5TA2HiRbPt0q5SlkPO5VuRzTql53f2/yNyfafmTO1um3CkNI/ulsAil1N oKYs2Jk76WP4PUeI+81HlTtaRhc31mv31geC2MxoThK30ieFl4QND6EwWeMGdvde8d6x Y3bwo2qMz2wOFT706WJ1lBdAvOg1Oj6K7y3/zBsfLy995aDu0e4dvNYrliweb2uIewLy DjlsAKHTLW4GRfDvJ7Tz7ENftdQN0ydG5PvX2qAZv3ppf9I8yYJvc60wY+UX1Mrtrtyu QvRg== X-Forwarded-Encrypted: i=1; AJvYcCVYPIwitdbvXDEdrXCmxFnczWS89ztWv3g8TL1u6j9mdLMYI4Z10Tj3K/NabAj1stWDVFJ/9wAKKS2QrOxZNJdz2jf5/so= X-Gm-Message-State: AOJu0YyIlRqq3acnbIu+e7Pu2buNu6HLEi7QzEseR8I4vwTw/FzfmRCV fWClMOYHGf1R2Ax8YcZbb74lRSMKmlACPiHamZz32PhpjZWKS0HY X-Google-Smtp-Source: AGHT+IG1e7VfKAMxLpnIXstxTYV5j/mHI14GDunMWTMNbfgJ6HkzimGkxzWOp25498QVgeO37nJmtQ== X-Received: by 2002:a17:902:ce85:b0:1f6:a43f:5b38 with SMTP id d9443c01a7336-1f6d02d6523mr5089795ad.4.1717697098257; Thu, 06 Jun 2024 11:04:58 -0700 (PDT) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-1f6bd7ec4e0sm18167375ad.236.2024.06.06.11.04.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Jun 2024 11:04:57 -0700 (PDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286717 Archived-At: On 6/6/2024 2:20 AM, Stefan Kangas wrote: > Jim Porter writes: > >> If anyone has time to test, I'd be interested to see if the results are >> similarly good on other platforms (I'm testing on x86_64 GNU/Linux), but >> I imagine they're comparable. > > 0. emacs -Q > 1. M-x eshell RET > 2. time cat config.log RET > > I did three attempts: > > Before your patch: 4.520 4.687 4.609 secs > With your patch: 0.958 0.968 1.048 secs Thanks. Those differences aren't quite as stark as in my tests, but 4.5x faster is still pretty substantial, so it's good to see this improves things on other systems too.