bug#16636: 24.3.50; REGRESSION: y/n file dialog is only flashed; input is not read

[Drew Adams <drew.adams@oracle.com>]

emacs -Q

Eval this after bring up Dired:

(defun diredp-mouse-find-file-other-frame (event)
  (interactive "e")
  (let ((pop-up-frames  t)) (dired-mouse-find-file-other-window event)))

(define-key dired-mode-map [M-mouse-2] 'diredp-mouse-find-file-other-frame)

In another Emacs session, modify one of the files listed in the Dired
buffer.  Then click M-mouse-2 on it in the Dired buffer.

In my own setup I at least see a brief flash of a message.  I see
nothing at all happen with emacs -Q.  I look in *Messages* but nothing
is recorded there ("normal").  There should have been a file dialog
displayed, and it should have waited for me to click y or n to dismiss
it.

Do `M-x debug-on-entry diredp-mouse-find-file-other-frame', then repeat:
click `M-mouse-2' on the same (modified) file.  Walk through the
debugger and you will see the file dialog displayed as it should be
(since `use-file-dialog' = t):

 File blah.el changed on disk. Reread from disk?

That is the message that was flashed (in my setup, at least).  It
disappeared as soon as it was displayed, and it did not wait for any
mouse-click confirmation or canceling.


In GNU Emacs 24.3.50.1 (i686-pc-mingw32)
 of 2014-02-02 on ODIEONE
Bzr revision: 116242 rudalics@gmx.at-20140202130041-n967dw77nw7ztvy9
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/binary --enable-checking=yes,glyphs
 'CFLAGS=-O0 -g3' LDFLAGS=-Lc:/Devel/emacs/lib
 CPPFLAGS=-Ic:/Devel/emacs/include'