From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#45539: 26.3; `add-to-ordered-list': Add optional arg for :test predicate for hash table Date: Tue, 29 Dec 2020 13:04:44 -0800 (PST) Message-ID: <1af7f2ac-0e6c-4c8a-860b-22148265d8aa@default> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28489"; mail-complaints-to="usenet@ciao.gmane.io" To: 45539@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 29 22:07:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kuMCz-0007IG-Vu for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Dec 2020 22:07:10 +0100 Original-Received: from localhost ([::1]:39890 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kuMCz-0004vf-1D for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Dec 2020 16:07:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34234) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kuMCs-0004vY-Vc for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 16:07:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57035) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kuMCs-0007UP-Hw for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 16:07:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kuMCs-0004y2-9q for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 16:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Dec 2020 21:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 45539 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.160927601719075 (code B ref -1); Tue, 29 Dec 2020 21:07:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 29 Dec 2020 21:06:57 +0000 Original-Received: from localhost ([127.0.0.1]:40348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuMCm-0004xb-Qi for submit@debbugs.gnu.org; Tue, 29 Dec 2020 16:06:57 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:34038) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuMCl-0004xT-Oj for submit@debbugs.gnu.org; Tue, 29 Dec 2020 16:06:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34212) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kuMCl-0004vQ-5V for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 16:06:55 -0500 Original-Received: from aserp2130.oracle.com ([141.146.126.79]:48922) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kuMCg-0007QX-Pm for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 16:06:54 -0500 Original-Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BTL4Pth152157 for ; Tue, 29 Dec 2020 21:06:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=rlj8nD2fz6LsY86gVF/RFh9QeZvuPhfeoV03k4E8pYU=; b=KMiPfLBjo0aZB52t6LOEeRlZa8J4RASg6V6m5pDtmY2d1jSs9oI8mdzB+uF9IuZi1dqm ZlPpElfKo/3TeWsfXF/Dj89tX0H4B3VH0GB3G6gg7jKPfGhDLqTjOYB2za/RRBX5vruf r9n9Z6mL5m0NjBwb+c9VITADaGgSYJJ/VrAoXEoPaa1no/mJoT/GWhFSvp2ajIwELuiT r87Iifk76eP2OtdAVds3/EojF4L48WNhDMt5Ol6Rt6UZCeEjWMNuO64UwAc1t6hfg7AY hbepYm6P/pPGz4NE3FzWuTsUJF/GXSfhbWNjCkgLRqsYAbqNHs2Hez6nHFHVHdaOMXMI gg== Original-Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2130.oracle.com with ESMTP id 35ntpaqbn8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 29 Dec 2020 21:06:46 +0000 Original-Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BTKt2Hm040641 for ; Tue, 29 Dec 2020 21:04:46 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 35pf3x304n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 29 Dec 2020 21:04:45 +0000 Original-Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0BTL4ibK009965 for ; Tue, 29 Dec 2020 21:04:45 GMT X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5095.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9849 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 adultscore=0 mlxlogscore=999 suspectscore=0 spamscore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012290129 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9849 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 adultscore=0 mlxscore=0 mlxlogscore=999 clxscore=1015 phishscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012290130 Received-SPF: pass client-ip=141.146.126.79; envelope-from=drew.adams@oracle.com; helo=aserp2130.oracle.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196976 Archived-At: Subject line says it all. I had never heard of `add-to-ordered-list' before coming across this user question: https://emacs.stackexchange.com/q/62520/105 Why hard-code the hash-table :test predicate? The fact of using a hash table should be only an internal, implementation thing. But the comparison behavior for the ordering is a user thing. Please consider adding an optional arg TEST-PREDICATE, which will be passed to the hash table (and which will default to `eq'). In GNU Emacs 26.3 (build 1, x86_64-w64-mingw32) of 2019-08-29 Repository revision: 96dd0196c28bc36779584e47fffcca433c9309cd Windowing system distributor `Microsoft Corp.', version 10.0.18362 Configured using: `configure --without-dbus --host=3Dx86_64-w64-mingw32 --without-compress-install 'CFLAGS=3D-O2 -static -g3''