all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: 45539@debbugs.gnu.org
Subject: bug#45539: 26.3; `add-to-ordered-list': Add optional arg for :test predicate for hash table
Date: Tue, 29 Dec 2020 13:04:44 -0800 (PST)	[thread overview]
Message-ID: <1af7f2ac-0e6c-4c8a-860b-22148265d8aa@default> (raw)

Subject line says it all.

I had never heard of `add-to-ordered-list' before coming across this
user question:

https://emacs.stackexchange.com/q/62520/105

Why hard-code the hash-table :test predicate?  The fact of using a hash
table should be only an internal, implementation thing.  But the
comparison behavior for the ordering is a user thing.

Please consider adding an optional arg TEST-PREDICATE, which will be
passed to the hash table (and which will default to `eq').

In GNU Emacs 26.3 (build 1, x86_64-w64-mingw32)
 of 2019-08-29
Repository revision: 96dd0196c28bc36779584e47fffcca433c9309cd
Windowing system distributor `Microsoft Corp.', version 10.0.18362
Configured using:
 `configure --without-dbus --host=x86_64-w64-mingw32
 --without-compress-install 'CFLAGS=-O2 -static -g3''





             reply	other threads:[~2020-12-29 21:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-29 21:04 Drew Adams [this message]
2020-12-30  3:48 ` bug#45539: 26.3; `add-to-ordered-list': Add optional arg for :test predicate for hash table Lars Ingebrigtsen
2020-12-30  7:01   ` Drew Adams
2020-12-30  7:07     ` Lars Ingebrigtsen
2020-12-30  8:43       ` Drew Adams
2020-12-30 17:55         ` Drew Adams
2020-12-31  3:55           ` Lars Ingebrigtsen
2020-12-31  4:30             ` Lars Ingebrigtsen
2020-12-31  5:47               ` Drew Adams
2020-12-31 16:40                 ` Drew Adams
2020-12-31  5:34             ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1af7f2ac-0e6c-4c8a-860b-22148265d8aa@default \
    --to=drew.adams@oracle.com \
    --cc=45539@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.