From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: regexp linting run in Emacs tree Date: Mon, 5 Aug 2019 10:17:38 -0700 Organization: UCLA Computer Science Department Message-ID: <1adc8c6d-7e82-6ee6-1ec5-12e387acecb1@cs.ucla.edu> References: <3B0BC169-9F40-456F-B249-0ABB43558EEA@acm.org> <2dcc229d-75ce-51df-0224-f484eec622e3@cs.ucla.edu> <1C885731-EC94-47DB-88D6-14C505C1BDF0@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="244850"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 Cc: Emacs Development To: =?UTF-8?Q?Mattias_Engdeg=c3=a5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 05 19:17:52 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hugcJ-0011VP-UZ for ged-emacs-devel@m.gmane.org; Mon, 05 Aug 2019 19:17:52 +0200 Original-Received: from localhost ([::1]:56256 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hugcI-0002EW-Gs for ged-emacs-devel@m.gmane.org; Mon, 05 Aug 2019 13:17:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45009) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hugcD-0002EC-IT for Emacs-devel@gnu.org; Mon, 05 Aug 2019 13:17:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hugcC-0000Da-Ma for Emacs-devel@gnu.org; Mon, 05 Aug 2019 13:17:45 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:46928) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hugcC-0000DE-HY for Emacs-devel@gnu.org; Mon, 05 Aug 2019 13:17:44 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 5E9D416007D; Mon, 5 Aug 2019 10:17:43 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id AUivXHhGdGQ4; Mon, 5 Aug 2019 10:17:42 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B7C631626E5; Mon, 5 Aug 2019 10:17:42 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id TG3k7lUrQLb5; Mon, 5 Aug 2019 10:17:42 -0700 (PDT) Original-Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 9549C16007D; Mon, 5 Aug 2019 10:17:42 -0700 (PDT) In-Reply-To: <1C885731-EC94-47DB-88D6-14C505C1BDF0@acm.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239193 Archived-At: Mattias Engdeg=C3=A5rd wrote: > What about the fairly lightweight attached patch? It's about as cheap a= s can be, while keeping it readable. I'm afraid that'd still be more clutter than it's worth, at least to me. Instead, how about changing the delinter to omit this particular warning = if the=20 regexp was computed from a configurable variable (as opposed to an ordina= ry=20 variable)?