From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#41879: 28.0.50; [Patch]: Add project-switch-to-buffer in project.el Date: Tue, 16 Jun 2020 02:38:21 +0300 Message-ID: <1a426f88-dd6e-77f7-bcbf-30ced285537d@yandex.ru> References: <87bllk2pfc.fsf@thornhill.no> <87sgew7zni.fsf@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="23457"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 To: Theodor Thornhill , 41879@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 16 01:39:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jkyh7-000612-OO for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 Jun 2020 01:39:13 +0200 Original-Received: from localhost ([::1]:49902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkyh6-0005Fo-MP for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Jun 2020 19:39:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35124) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkygw-0005Fb-9U for bug-gnu-emacs@gnu.org; Mon, 15 Jun 2020 19:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36119) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jkygw-00038d-0V for bug-gnu-emacs@gnu.org; Mon, 15 Jun 2020 19:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jkygv-0007MP-TY for bug-gnu-emacs@gnu.org; Mon, 15 Jun 2020 19:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Jun 2020 23:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41879 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41879-submit@debbugs.gnu.org id=B41879.159226431228254 (code B ref 41879); Mon, 15 Jun 2020 23:39:01 +0000 Original-Received: (at 41879) by debbugs.gnu.org; 15 Jun 2020 23:38:32 +0000 Original-Received: from localhost ([127.0.0.1]:47665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkygR-0007Ld-Nf for submit@debbugs.gnu.org; Mon, 15 Jun 2020 19:38:32 -0400 Original-Received: from mail-wr1-f51.google.com ([209.85.221.51]:42319) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkygQ-0007LR-1D for 41879@debbugs.gnu.org; Mon, 15 Jun 2020 19:38:30 -0400 Original-Received: by mail-wr1-f51.google.com with SMTP id p5so18831059wrw.9 for <41879@debbugs.gnu.org>; Mon, 15 Jun 2020 16:38:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YfVWW0vwPpoj06W3o9tlAnzZOlsxfJWjgS8oWjqp3WM=; b=L+XbCxdeqO9ZQu/OpRj7jkj6TLva2QRLzn/bGw85aCssT1s0vyDVTiiqXmdbGgypIl 23h/p8AfKDdpGRD1CTET5+gSocDGy1aQiTAM7uc+goXTpB3EfXKtOls2cZZsHHnjuNlz gKFrkaj3slORV/kRsdQVbNH0pmPsCCceKVz+F8y1KgqzD/mqF6WiKJiZoCytzXN0p/Um 9cEbb16xoCmDOagsxmi55NUN/JeZyPbBIuXA2x4vgF4SCEysSuPtYMvhZOwx5L7/+Hjx 1X+snE44zTbTn0vcrkYdbXmUj/ZtaZeiEbMqsjjJxhsj91wPtEIspALwH/TQuzadqGXu Fvbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YfVWW0vwPpoj06W3o9tlAnzZOlsxfJWjgS8oWjqp3WM=; b=un2ivuFjV8HSjo1CN22wRqKk+7oRLtpqPzI039WnH5KN8e97pNeIBNjIPGam2PF+7K Ct47YiL2GfbHH+IWISsv4QOceib+ik6lCrTi8/3boRmOcXc2hwLnmyKPLmUQfNuvWH4t 2vawozwAmg8Xgm37cloiTF0/9BUraqJfUrtiuEjdYJTDBLVQkYTSCigP4LaJRNa0VJDU 9dgwieu87C2Qjs2zR9xnzNUxdhi87awyOJ0wug2fWeRGER24Hemq0I7WYhcMkHjdaexk KFapkBiClTirIryriQuGVozd14WCsKKbzxPwjMZQSN3jxAD55y73bojjwMbtdY95PzJh bwow== X-Gm-Message-State: AOAM531BqVQ0vYcCc+sog9KYqWIlCWjm/6z1wU2BqSXzk4lgZHJ8YpeW n9UJ3Ub2a0a5Ae5LB4JlXI2TV1PF X-Google-Smtp-Source: ABdhPJxV0UU8ejpijgevinsp4bBrX9wdt+3vgV99z3TNgUhyFalyqcQMQWUAdS+6Ewpm+VJCsxQqDg== X-Received: by 2002:a5d:5303:: with SMTP id e3mr30786412wrv.321.1592264303747; Mon, 15 Jun 2020 16:38:23 -0700 (PDT) Original-Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id z7sm25956313wrt.6.2020.06.15.16.38.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2020 16:38:23 -0700 (PDT) In-Reply-To: <87sgew7zni.fsf@thornhill.no> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182000 Archived-At: Thank you. On 16.06.2020 01:05, Theodor Thornhill wrote: > What do you think? A few more notes. :-) > + "Switch-to-buffer: " nil nil The REQUIRE-MATCH argument should be t, I think. > + (lambda (buffer) > + (when-let* ((path (buffer-file-name (cdr buffer))) The word "path" is reserved for something else (e.g. exec-path) in the GNU project. Call it file or file-name. > + (true (file-truename path))) Do we need this conversion? It'll add some runtime overhead, and I'm not sure in which conditions the result will be different. > + (when (file-in-directory-p true (project-root pr)) > + 'buffer))))))) Why 'buffer and not t?