* bug#9901: xg_win_to_widget uninitialized access
@ 2011-10-29 1:59 Dan Nicolaescu
2011-10-30 17:32 ` Jan Djärv
0 siblings, 1 reply; 2+ messages in thread
From: Dan Nicolaescu @ 2011-10-29 1:59 UTC (permalink / raw
To: 9901
valgrind gives a warning for an uninitialized access in
xg_win_to_widget for the gtk_get_event_widget call.
if (gdkwin)
{
GdkEvent event;
event.any.window = gdkwin;
gwdesc = gtk_get_event_widget (&event);
}
gtk_get_event_widget is (in gtk3):
GtkWidget*
gtk_get_event_widget (GdkEvent *event)
{
GtkWidget *widget;
gpointer widget_ptr;
widget = NULL;
if (event && event->any.window &&
(event->type == GDK_DESTROY || !gdk_window_is_destroyed
(event->any.window)))
{
gdk_window_get_user_data (event->any.window, &widget_ptr);
widget = widget_ptr;
}
return widget;
}
so indeed event->type is uninitialized.
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#9901: xg_win_to_widget uninitialized access
2011-10-29 1:59 bug#9901: xg_win_to_widget uninitialized access Dan Nicolaescu
@ 2011-10-30 17:32 ` Jan Djärv
0 siblings, 0 replies; 2+ messages in thread
From: Jan Djärv @ 2011-10-30 17:32 UTC (permalink / raw
To: Dan Nicolaescu; +Cc: 9901-done
Fixed.
Jan D.
29 okt 2011 kl. 03:59 skrev Dan Nicolaescu:
> valgrind gives a warning for an uninitialized access in
> xg_win_to_widget for the gtk_get_event_widget call.
>
>
> if (gdkwin)
> {
> GdkEvent event;
> event.any.window = gdkwin;
> gwdesc = gtk_get_event_widget (&event);
> }
>
> gtk_get_event_widget is (in gtk3):
>
> GtkWidget*
> gtk_get_event_widget (GdkEvent *event)
> {
> GtkWidget *widget;
> gpointer widget_ptr;
>
> widget = NULL;
> if (event && event->any.window &&
> (event->type == GDK_DESTROY || !gdk_window_is_destroyed
> (event->any.window)))
> {
> gdk_window_get_user_data (event->any.window, &widget_ptr);
> widget = widget_ptr;
> }
>
> return widget;
> }
>
> so indeed event->type is uninitialized.
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-30 17:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-29 1:59 bug#9901: xg_win_to_widget uninitialized access Dan Nicolaescu
2011-10-30 17:32 ` Jan Djärv
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.