From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#12281: 24.1.50; [PATCH] regression: `dired-pop-to-buffer': `set-window-start' to 1 Date: Sat, 25 Aug 2012 21:53:37 -0700 Message-ID: <1FB857F70592465AAD8D4DD0A0634860@us.oracle.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1345956864 22996 80.91.229.3 (26 Aug 2012 04:54:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 26 Aug 2012 04:54:24 +0000 (UTC) To: 12281@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 26 06:54:25 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T5Ure-0002eR-H6 for geb-bug-gnu-emacs@m.gmane.org; Sun, 26 Aug 2012 06:54:22 +0200 Original-Received: from localhost ([::1]:39621 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T5Urc-00081e-Q4 for geb-bug-gnu-emacs@m.gmane.org; Sun, 26 Aug 2012 00:54:20 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:36305) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T5UrZ-0007yE-OZ for bug-gnu-emacs@gnu.org; Sun, 26 Aug 2012 00:54:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T5UrY-0000yb-TK for bug-gnu-emacs@gnu.org; Sun, 26 Aug 2012 00:54:17 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39685) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T5UrY-0000yV-Po for bug-gnu-emacs@gnu.org; Sun, 26 Aug 2012 00:54:16 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1T5UsH-0007cy-OW for bug-gnu-emacs@gnu.org; Sun, 26 Aug 2012 00:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Aug 2012 04:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 12281 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: Original-Received: via spool by submit@debbugs.gnu.org id=B.134595688229290 (code B ref -1); Sun, 26 Aug 2012 04:55:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 26 Aug 2012 04:54:42 +0000 Original-Received: from localhost ([127.0.0.1]:49231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T5Urx-0007cN-SH for submit@debbugs.gnu.org; Sun, 26 Aug 2012 00:54:42 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60426) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T5Urv-0007cG-LY for submit@debbugs.gnu.org; Sun, 26 Aug 2012 00:54:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T5UrA-0000xa-8n for submit@debbugs.gnu.org; Sun, 26 Aug 2012 00:53:54 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:49190) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T5UrA-0000xW-5w for submit@debbugs.gnu.org; Sun, 26 Aug 2012 00:53:52 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:36261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T5Ur9-0007uU-6T for bug-gnu-emacs@gnu.org; Sun, 26 Aug 2012 00:53:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T5Ur8-0000xG-9z for bug-gnu-emacs@gnu.org; Sun, 26 Aug 2012 00:53:51 -0400 Original-Received: from acsinet15.oracle.com ([141.146.126.227]:18602) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T5Ur8-0000xC-3e for bug-gnu-emacs@gnu.org; Sun, 26 Aug 2012 00:53:50 -0400 Original-Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q7Q4rl6o026607 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 26 Aug 2012 04:53:48 GMT Original-Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q7Q4rkZq025584 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 26 Aug 2012 04:53:47 GMT Original-Received: from abhmt116.oracle.com (abhmt116.oracle.com [141.146.116.68]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q7Q4rkgu011849 for ; Sat, 25 Aug 2012 23:53:46 -0500 Original-Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 25 Aug 2012 21:53:46 -0700 X-Mailer: Microsoft Office Outlook 11 Thread-Index: Ac2DRsDyNX1hBvM/RrOX/E1G7yc6/g== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:63498 Archived-At: This regression was introduced in Emacs 23. Prior to Emacs 23, `dired-pop-to-buffer' had a more complex definition, which included calling `set-window-start' for the displayed window, setting the value to 1, to move to the buffer beginning. Now, at least for the case where the buffer is popped up in a separate frame (which is my case), the end of the buffer is shown, not the beginning. For example, if I use `C' to copy many files, the file list shows up in a separate frame, but the window is scrolled so I see only the end, not the beginning, of the buffer. Please add this line before the call to `when': (set-window-start (selected-window) 1) That fixes things. Here is the whole, patched definition. (defun dired-pop-to-buffer (buf) "Pop up buffer BUF in a way suitable for Dired." (let ((split-window-preferred-function (lambda (window) (or (and (let ((split-height-threshold 0)) (window-splittable-p (selected-window))) ;; Try to split the selected window vertically if ;; that's possible. (Bug#1806) (split-window-below)) ;; Otherwise, try to split WINDOW sensibly. (split-window-sensibly window)))) pop-up-frames) (pop-to-buffer (get-buffer-create buf))) (set-window-start (selected-window) 1) ;; If dired-shrink-to-fit is t, make its window fit its contents. (when dired-shrink-to-fit ;; Try to not delete window when we want to display less than ;; `window-min-height' lines. (fit-window-to-buffer (get-buffer-window buf) nil 1))) In GNU Emacs 24.1.50.1 (i386-mingw-nt5.1.2600) of 2012-08-13 on MARVIN Bzr revision: 109584 monnier@iro.umontreal.ca-20120813141247-76irjqslrfncn30u Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.6) --no-opt --enable-checking --cflags -ID:/devel/emacs/libs/libXpm-3.5.8/include -ID:/devel/emacs/libs/libXpm-3.5.8/src -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include -ID:/devel/emacs/libs/giflib-4.1.4-1/include -ID:/devel/emacs/libs/jpeg-6b-4/include -ID:/devel/emacs/libs/tiff-3.8.2-1/include -ID:/devel/emacs/libs/gnutls-3.0.9/include -ID:/devel/emacs/libs/libiconv-1.13.1-1-dev/include -ID:/devel/emacs/libs/libxml2-2.7.8/include/libxml2'