all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Theodor Thornhill <theo@thornhill.no>
To: emacs-devel@gnu.org, Yuan Fu <casouri@gmail.com>,
	emacs-devel <emacs-devel@gnu.org>
Subject: Re: Mode names for C-like tree-sitter modes
Date: Mon, 14 Nov 2022 07:34:48 +0100	[thread overview]
Message-ID: <1E870C80-8435-4305-8FA1-A5A8FF681E2C@thornhill.no> (raw)
In-Reply-To: <3C23FEAC-6550-48BE-91A3-443B44717C40@gmail.com>



On 14 November 2022 02:16:13 CET, Yuan Fu <casouri@gmail.com> wrote:
>Thanks to Theo’s great work, we now have tree-sitter powered major modes for C, C++, Java, JSON, CSS. Right now they are named c-ts-mode, c++-ts-mode, java-ts-mode, etc. And c-ts-mode and c++-ts-mode inherits from a dummy mode c-ts-mode--base-mode.
>
>I think it’s fair to make C, C++ and Java modes independent, since all the cc-mode options are invalidated when we use tree-sitter. However, their name could be improved, IMO. But I can’t think of anything better than c-ts-mode :-)
>
>(neo-c-mode… just saying)
>

I agree and can't think of a better name either...

>c-ts-mode--base-mode should probably be a public mode, since the intention (IIUC) is enable users to configure C and C++ together, by adding hooks to this base-mode. So something like c-base-mode or c-ts-base-mode?
>

Sure!

>CSS and JSON could be merged with current modes, I think. Css-ts-mode could merge with css-mode, and json-ts-mode could be merged with js-json-mode. Or we can just have a dedicated json-mode.
>
>Theo, WDYT?
>

That's fine with me. In any case I think we should remove tree-sitter support from js-json-mode (or merge them). I think there exist a json-mode  in both elpa and melpa, adding another isn't the best idea I think. 

Not sure what is best, really.

My vote goes to merging css and keeping others separate, but I don't have the strongest opinion there. 

I can prepare such a patch after we decide on something.

Theo



  reply	other threads:[~2022-11-14  6:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-14  1:16 Mode names for C-like tree-sitter modes Yuan Fu
2022-11-14  6:34 ` Theodor Thornhill [this message]
2022-11-14  9:09   ` Yuan Fu
2022-11-14  9:49     ` Theodor Thornhill
2022-11-14 10:07       ` Theodor Thornhill
2022-11-14 10:17     ` Simen Heggestøyl
2022-11-15  2:49     ` Stefan Monnier
2022-11-14 19:04 ` Eli Zaretskii
2022-11-15  4:17 ` Richard Stallman
2022-11-15  6:33   ` Theodor Thornhill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1E870C80-8435-4305-8FA1-A5A8FF681E2C@thornhill.no \
    --to=theo@thornhill.no \
    --cc=casouri@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.