From: "Jan Djärv" <jan.h.d@swipnet.se>
To: Kai Tetzlaff <kai.tetzlaff@web.de>
Cc: 10103@debbugs.gnu.org
Subject: bug#10103: 24.0.91; Emacs/nextstep ignores frame geometry from org.gnu.Emacs.plist
Date: Sat, 10 Dec 2011 15:01:59 +0100 [thread overview]
Message-ID: <1DF79C6D-9B32-4A7F-BDFC-DA26B77C9F37@swipnet.se> (raw)
In-Reply-To: <7iobvndf3c.fsf@mack.tetzco.de>
Hello.
5 dec 2011 kl. 01:41 skrev Kai Tetzlaff:
> Hi,
>
> Jan Djärv <jan.h.d@swipnet.se> writes:
>> 22 nov 2011 kl. 07:51 skrev Kai Tetzlaff:
>>> Since about 3 weeks, the nextstep port started to ignore frame geometry
>>> parameters (i.e. Top, Left, Height, Width) from
>>> ~/Library/Preferences/org.gnu.Emacs.plist (while some other parameters
>>> like ToolBar and Background still seem to be working).
>>>
>>
>> That was a cleanup that removed too much. Now restored.
> Nice, thank you!
>
> When i first started Emacs after the fix, i got an immediate crash.
> After some debugging, i found that i had accidentally changed the type
> of the Height property from String to Integer. While trying to
> understand what is happening i found that the following patch allows to
> use either Integer or String type values in the plist file:
>
> === modified file 'src/nsfns.m'
> --- src/nsfns.m 2011-12-04 13:25:16 +0000
> +++ src/nsfns.m 2011-12-05 00:07:20 +0000
> @@ -2217,7 +2217,7 @@
> /* --quick was passed, so this is a no-op. */
> return NULL;
>
> - res = [[[NSUserDefaults standardUserDefaults] objectForKey:
> + res = [[[NSUserDefaults standardUserDefaults] stringForKey:
> [NSString stringWithUTF8String: toCheck]] UTF8String];
> return !res ? NULL :
> (!strncasecmp (res, "YES", 3) ? "true" :
>
>
> Would it make sense to change objectForKey to stringForKey (in this and
> some other places) when trying to retrieve a string type property from a
> plist file?
It does not work that way for me. The documentation says that stringForKey returns:
"The string associated with the specified key, or nil if the default does not exist or does not contain a string."
and indeed, I get nil if I put in an integer for height, which makes UTF8String throw an exception. This is the same behaviour as with objectForKey. I tested on OSX 10.7, it may be different on other versions.
It does make sense to avoid crashing on bad user input, so I fixed it in another way.
Jan D.
next prev parent reply other threads:[~2011-12-10 14:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 6:51 bug#10103: 24.0.91; Emacs/nextstep ignores frame geometry from org.gnu.Emacs.plist Kai Tetzlaff
2011-12-04 13:27 ` Jan Djärv
2011-12-05 0:41 ` Kai Tetzlaff
2011-12-10 14:01 ` Jan Djärv [this message]
2011-12-11 12:15 ` Kai Tetzlaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1DF79C6D-9B32-4A7F-BDFC-DA26B77C9F37@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=10103@debbugs.gnu.org \
--cc=kai.tetzlaff@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.