From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: regexp linting run in Emacs tree Date: Mon, 5 Aug 2019 13:33:10 +0200 Message-ID: <1C885731-EC94-47DB-88D6-14C505C1BDF0@acm.org> References: <3B0BC169-9F40-456F-B249-0ABB43558EEA@acm.org> <2dcc229d-75ce-51df-0224-f484eec622e3@cs.ucla.edu> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_BCD627D4-D32E-4AD6-8EC5-B93EBEFD1771" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="92039"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Emacs Development To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 05 13:33:35 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hubF8-000Npg-DY for ged-emacs-devel@m.gmane.org; Mon, 05 Aug 2019 13:33:34 +0200 Original-Received: from localhost ([::1]:52780 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hubF7-0007sT-7Z for ged-emacs-devel@m.gmane.org; Mon, 05 Aug 2019 07:33:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57708) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hubF2-0007sM-Lf for Emacs-devel@gnu.org; Mon, 05 Aug 2019 07:33:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hubF0-0004fB-VG for Emacs-devel@gnu.org; Mon, 05 Aug 2019 07:33:28 -0400 Original-Received: from mail237c50.megamailservers.eu ([91.136.10.247]:44388 helo=mail56c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hubF0-0004cM-22 for Emacs-devel@gnu.org; Mon, 05 Aug 2019 07:33:26 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1565004793; bh=+0io5KjQeRNue/waSXD9D4feWpM7hGhz1cc6dzl9TB4=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=E0LxrmGBoJrRSeAUoAShdiZgkAOv95PgXtWI8i7LQyDyY3QYtNZcCvcs/LVetjP8c wfZfitl87pVHCBpj5fpcYrf6stVScYOuvUeWZurOMcoMv0cMIiE336U+wYKRLQ2CSV ZtFL3bTTlDR9/hY93OfGj62lqyQONwdtmm3mItTI= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail56c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x75BXBB2006573; Mon, 5 Aug 2019 11:33:13 +0000 In-Reply-To: <2dcc229d-75ce-51df-0224-f484eec622e3@cs.ucla.edu> X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B020B.5D4813F9.0057, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=IZipp1ia c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=dSAaY7uBXeVgJpI0iLkA:9 a=CjuIK1q_8ugA:10 a=-THELPMcS0zLYK4wp48A:9 a=B2y7HmGcmWMA:10 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 91.136.10.247 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239179 Archived-At: --Apple-Mail=_BCD627D4-D32E-4AD6-8EC5-B93EBEFD1771 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 5 aug. 2019 kl. 00.57 skrev Paul Eggert : >=20 >> relint blindly assumes default values of global variables. What about = adding a `delete-dups' to make it shut up? >=20 > That would slow down and complicate the source a bit. Maybe just add = the glitch to the delinter's exception list, if any. There isn't one and I had hoped not having to add such a mechanism. = Partly because it is a cop-out, and partly because it, too, would litter = the source with alien comments like ;; relint: skip-set-duplicate the kind of which, in my experience, tend to linger far beyond their = usefulness and mystify innocent readers of the code. (Sticking the suppressions in a separate .relint-exceptions file is not = a better solution.) What about the fairly lightweight attached patch? It's about as cheap as = can be, while keeping it readable. > Oh, thanks, I see the point now. I installed the attached. Good, thank you. I especially like how you removed the "FIXME: replace = it with something shorter" comment, since you did, in effect, do just = that! --Apple-Mail=_BCD627D4-D32E-4AD6-8EC5-B93EBEFD1771 Content-Disposition: attachment; filename=0001-Shut-up-regexp-linter.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Shut-up-regexp-linter.patch" Content-Transfer-Encoding: quoted-printable =46rom=202c648f73207813787175776e76fba426d67cb9f0=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Mon,=205=20Aug=202019=2012:59:53=20+0200=0A= Subject:=20[PATCH]=20Shut=20up=20regexp=20linter=0A=0A*=20= lisp/progmodes/fortran.el=20(fortran-indent-to-column):=0APrevent=20= relint=20from=20complaining=20about=20a=20duplicated=20character=20in=20= the=0Aargument=20to=20skip-chars-{forward,backward}.=0A---=0A=20= lisp/progmodes/fortran.el=20|=204=20+++-=0A=201=20file=20changed,=203=20= insertions(+),=201=20deletion(-)=0A=0Adiff=20--git=20= a/lisp/progmodes/fortran.el=20b/lisp/progmodes/fortran.el=0Aindex=20= f01e866f55..8f58c501e4=20100644=0A---=20a/lisp/progmodes/fortran.el=0A= +++=20b/lisp/progmodes/fortran.el=0A@@=20-1818,7=20+1818,9=20@@=20= fortran-indent-to-column=0A=20=20=20=20=20=20=20=20=20=20=20=20=20(let*=20= ((char=20(if=20(stringp=20fortran-comment-indent-char)=0A=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (aref=20fortran-comment-indent-char=200)=0A=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= fortran-comment-indent-char))=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20(chars=20(string=20?\s=20?\t=20char)))=0A+=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20(chars=20(if=20(memq=20char=20= '(?\s=20?\t))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20"=20\t"=0A+=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(string=20?\s=20= ?\t=20char))))=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(goto-char=20= (match-end=200))=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (skip-chars-backward=20chars)=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20(delete-region=20(point)=20(progn=20(skip-chars-forward=20chars)=0A--=20= =0A2.20.1=20(Apple=20Git-117)=0A=0A= --Apple-Mail=_BCD627D4-D32E-4AD6-8EC5-B93EBEFD1771--