From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: JD Smith Newsgroups: gmane.emacs.bugs Subject: bug#71384: treesit-font-lock-fontify-region unnecessarily re-unfontify's Date: Wed, 5 Jun 2024 18:06:54 -0400 Message-ID: <1BA07683-10C0-4335-8C35-C260D049908B@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26380"; mail-complaints-to="usenet@ciao.gmane.io" To: 71384@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 06 00:56:16 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sEzYG-0006kJ-FJ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Jun 2024 00:56:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sEzXp-00048y-GZ; Wed, 05 Jun 2024 18:55:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEzXn-000484-V5 for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 18:55:47 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sEzXn-0006JR-MD for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 18:55:47 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sEzY1-0006sU-OY for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 18:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: JD Smith Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Jun 2024 22:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 71384 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.171762814926404 (code B ref -1); Wed, 05 Jun 2024 22:56:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 5 Jun 2024 22:55:49 +0000 Original-Received: from localhost ([127.0.0.1]:44576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEzXo-0006ro-Kc for submit@debbugs.gnu.org; Wed, 05 Jun 2024 18:55:48 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:60698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEzXm-0006re-SF for submit@debbugs.gnu.org; Wed, 05 Jun 2024 18:55:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEymo-0001AT-SV for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 18:07:14 -0400 Original-Received: from mail-qv1-xf31.google.com ([2607:f8b0:4864:20::f31]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sEymm-0005q0-Q3 for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 18:07:14 -0400 Original-Received: by mail-qv1-xf31.google.com with SMTP id 6a1803df08f44-6ad8344825cso1289506d6.0 for ; Wed, 05 Jun 2024 15:07:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717625226; x=1718230026; darn=gnu.org; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:from:to:cc:subject:date:message-id:reply-to; bh=J4ZgHfJ3S4vSRZHJxQn8J1/cjmmSpZXmXBpF/6tU6pk=; b=jolasxwD1FDm6/gNdX2xGEc5bkEKkb4lORFoofwej9NJUVjPqBd8GbprZWgUlQe3BQ puzfoPIb/G+TSYp5CP1ye001rQXc9PvuBCPRwBqGd/1/SLJAo73cUOUKzgIw0RMMbXlG 2JVMLngt3p7yqB+lR8qeEQkLRWPzrI+SOONZgprJLxRUajwfQs+DjOyJP6m1tY/RRzwg WQ6ThP2z+SVsA6LYIipSCsvrYh8pvCcIuhfJ0b/xTQ/10rsCO6CRuK0X3DeTAkUOEYD0 IQ7fmYDDSyqycGQrk9t+z/CvH5ljH3MRRjq/ocnnlFxecrD7acjb/EDLa7JO6ZvNu90M Mv2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717625226; x=1718230026; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=J4ZgHfJ3S4vSRZHJxQn8J1/cjmmSpZXmXBpF/6tU6pk=; b=l7qQxQ5TVxkhhoyeH66BQTw673KhIf4skLYeaihW9PRIHkOqDMID9N64WPWyu3zMJZ 7GJvlbd+d7IbMe/wsFstVBM/RSyWxQKF6nulDMBUeRRWtcmQhzdEbCDOglrozkqs054b xBfmEqXh9c1Mz+Bo5LQsIWwkSYYNpWjS/+SrmiUFJjC7afFR8LYtzL3kwNU2KhowRos0 nIZ4CQLuLFqQtERZB/nEo2er5rMQO6yiOTHy5chNKP7HrgF7ODU6NVkKh83KkDfLzGY6 kpsHWom3FdwwYNpKXeXiPtWRmSJlYxxs9AahxVCJ3/tGcWg/fHrwuv++fVDRzdsHSaV6 zcDw== X-Gm-Message-State: AOJu0YwNltsz+vwl/t8LYJhHP6dPWAYsf7Zew8D8KVwaaKOinccJRlA0 oO6RNaMe6Ac3y1OaUW5Nx5tbqQHpEKJx1DF3r7KCLNSduH3mftgbNt840g== X-Google-Smtp-Source: AGHT+IHlFqauQ/XwOtTVtr/AruJvBLo6LScw3vAKRzerElZYUASnUCI875zhfztbKh0LcaPEgzJhKg== X-Received: by 2002:a05:6214:3b89:b0:6af:5257:9d1b with SMTP id 6a1803df08f44-6b031cecf16mr34239946d6.64.1717625226367; Wed, 05 Jun 2024 15:07:06 -0700 (PDT) Original-Received: from smtpclient.apple ([131.183.131.33]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b04f62518csm147856d6.26.2024.06.05.15.07.04 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Jun 2024 15:07:04 -0700 (PDT) X-Mailer: Apple Mail (2.3774.500.171.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::f31; envelope-from=jdtsmith@gmail.com; helo=mail-qv1-xf31.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286642 Archived-At: The function treesit-font-lock-fontify-region in treesit.el calls = (font-lock-unfontify-region start end) right away (see below). But this = function is called as the value of = font-lock-fontify-syntactically-function from = font-lock-default-fontify-region, which has just itself made the exact = same call to font-lock-unfontify-region. I commented out that = superfluous call in treesit-font-lock-fontify-region and noticed no ill = effects. (defun treesit-font-lock-fontify-region (start end &optional loudly) "Fontify the region between START and END. If LOUDLY is non-nil, display some debugging information." (when (or loudly treesit--font-lock-verbose) (message "Fontifying region: %s-%s" start end)) (treesit-update-ranges start end) (font-lock-unfontify-region start end)=