From: Yuan Fu <casouri@gmail.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 60127@debbugs.gnu.org, Danny Freeman <danny@dfreeman.email>
Subject: bug#60127: treesit-end-of-defun: possible bug with clojure grammar
Date: Sun, 15 Jan 2023 18:39:56 -0800 [thread overview]
Message-ID: <1B32D81E-3647-4FCA-A1C8-AFD8AFC96E78@gmail.com> (raw)
In-Reply-To: <6a7f5a94-b2cd-c6b8-1267-87da1c6303e1@yandex.ru>
> On Jan 15, 2023, at 5:56 PM, Dmitry Gutov <dgutov@yandex.ru> wrote:
>
> On 22/12/2022 10:55, Yuan Fu wrote:
>> Danny Freeman<danny@dfreeman.email> writes:
>>> Yuan,
>>>
>>>>> Thank you very much for this detailed report! This seems to be some
>>>>> problem with either tree-sitter or tree-sitter-clojure, where
>>>>> treesit-node-first-child-for-pos gives wrong result. We’ve had similar
>>>>> problem with bash before[1].
>>>>>
>>>>> At this point there aren’t much we can do in Emacs. If I find some time
>>>>> I’ll make a reproduce recipe and submit an issue on tree-sitter-clojure.
>>>>>
>>>>> [1]https://github.com/tree-sitter/tree-sitter-bash/issues/139
>>>>>
>>>>> Yuan
>>> I have a c program that I believe reproduces the problem. I'm not sure
>>> how we will go about fixing it in tree-sitter-clojure, but at least we
>>> have a minimal way to re-create it.
>>>
>>> Here is a link to the issue I created:
>>> https://github.com/sogaiu/tree-sitter-clojure/issues/32
>>> that also includes the c-program. I've also put it on my source hut
>>> https://paste.sr.ht/~dannyfreeman/8786059276c334036877159a5b0872cd2aa6fbc0
>>> If you find the time, I would appreciate it if you could confirm my
>>> findings. I'm a little in over my head with this bug I'm afraid.
>> I think it’s pretty good (the reproduce), the author’s modified program
>> is even better. Let’s wait and see what tree-sitter’s author have to
>> say.
>
> Just to keep everyone of the same page:
>
> clojure-tree-sitter's author posted an issue to tree-sitter last week: https://github.com/tree-sitter/tree-sitter/issues/2012
>
> and, previously, he also suggested we might be able to work around it using treesit_search_dfs: https://github.com/sogaiu/tree-sitter-clojure/issues/32#issuecomment-1364830835
I’d rather not use treesit_search_dfs, as it does much more work than the current code. You know what, I can write a custom ts_node_first_child_for_byte and use that in Emacs, I’ve already done that for ts_node_parent anyway.
Yuan
next prev parent reply other threads:[~2023-01-16 2:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 18:12 bug#60127: treesit-end-of-defun: possible bug with clojure grammar Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-16 23:20 ` Yuan Fu
2022-12-17 14:07 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-17 15:47 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-17 15:47 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-22 8:55 ` Yuan Fu
2023-01-16 1:56 ` Dmitry Gutov
2023-01-16 2:39 ` Yuan Fu [this message]
2023-01-17 9:30 ` Yuan Fu
2023-01-17 12:20 ` Eli Zaretskii
2023-01-17 15:49 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-05 15:57 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1B32D81E-3647-4FCA-A1C8-AFD8AFC96E78@gmail.com \
--to=casouri@gmail.com \
--cc=60127@debbugs.gnu.org \
--cc=danny@dfreeman.email \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.