From: John Paul Wallington <jpw@pobox.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Stephen Berman <Stephen.Berman@gmx.net>, emacs-devel@gnu.org
Subject: Re: M-x dired and read-file-name-completion-ignore-case
Date: Tue, 6 May 2008 00:14:23 +0100 [thread overview]
Message-ID: <1AF50928-B14E-4EF8-B18E-BFB384E4881E@pobox.com> (raw)
In-Reply-To: <jwvve1slfg9.fsf-monnier+emacs@gnu.org>
On 5 May 2008, at 20:27, Stefan Monnier wrote:
> The above patch should fix it,
>
>
> Stefan
>
>
> --- dired.el.~1.393.~ 2008-05-02 13:38:03.000000000 -0400
> +++ dired.el 2008-05-05 15:26:27.000000000 -0400
> @@ -607,6 +607,7 @@
> (lambda ()
> (setq minibuffer-default default)
> (setq minibuffer-completing-file-name t)
> + (setq completion-ignore-case read-file-name-
> completion-ignore-case)
> (setq default-directory defdir))
> (substitute-in-file-name
> (completing-read
I don't think that change is good because it globally clobbers
`completion-ignore-case' rather then let-binding it. How about
installing the following fix?
(diff -uw output, to ignore changing indentation):
--- dired.el.~1.394.~ 2008-05-05 23:36:20.000000000 +0100
+++ dired.el 2008-05-06 00:04:08.000000000 +0100
@@ -607,9 +607,8 @@
(lambda ()
(setq minibuffer-default default)
(setq minibuffer-completing-file-name t)
- (setq completion-ignore-case
- read-file-name-completion-ignore-case)
(setq default-directory defdir))
+ (let ((completion-ignore-case read-file-name-completion-
ignore-case))
(substitute-in-file-name
(completing-read
(format "Dired %s(directory): " str)
@@ -628,7 +627,7 @@
(complete-with-action
action 'read-file-name-internal str nil)))
'read-file-name-internal)
- nil nil (abbreviate-file-name defdir) 'file-name-
history))))))))
+ nil nil (abbreviate-file-name defdir) 'file-name-
history)))))))))
;;;###autoload (define-key ctl-x-map "d" 'dired)
;;;###autoload
next prev parent reply other threads:[~2008-05-05 23:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-05 9:28 M-x dired and read-file-name-completion-ignore-case Stephen Berman
2008-05-05 19:27 ` Stefan Monnier
2008-05-05 23:14 ` John Paul Wallington [this message]
2008-05-06 0:58 ` Stefan Monnier
2008-05-06 16:06 ` Stephen Berman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1AF50928-B14E-4EF8-B18E-BFB384E4881E@pobox.com \
--to=jpw@pobox.com \
--cc=Stephen.Berman@gmx.net \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.