From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= Newsgroups: gmane.emacs.devel Subject: Re: toml-ts-mode (code-review done) Date: Wed, 14 Dec 2022 23:02:22 +0100 Message-ID: <1A644743-4704-4897-A3E9-503C8215EE8B@secure.kjonigsen.net> References: <3233F4D7-AC3A-4A99-BBDE-03693E487C9A@gmail.com> Mime-Version: 1.0 (1.0) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3155"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 14 23:03:19 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5ZqO-0000YA-VJ for ged-emacs-devel@m.gmane-mx.org; Wed, 14 Dec 2022 23:03:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5Zpn-0006J9-4S; Wed, 14 Dec 2022 17:02:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5Zpl-0006Iv-Im for emacs-devel@gnu.org; Wed, 14 Dec 2022 17:02:37 -0500 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5Zpj-0003rK-Q4 for emacs-devel@gnu.org; Wed, 14 Dec 2022 17:02:37 -0500 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 486D65C0096; Wed, 14 Dec 2022 17:02:35 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 14 Dec 2022 17:02:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1671055355; x=1671141755; bh=WINIwtSwe3 wir98ARxc+1SeiNZ0IbhI7zwV5hmqGONk=; b=TzcdroiO2L1QPYfZdrb124GaYm cJ8YeurVmh9/Koe9EEqJw9iYjGzv0au4dbbwh1W6q8tcrnFN89pGda8dJexuJzty MKl4v6aM4ZrWpGAarmW0inaSmNaVmzzmr2/mHVZSUZQ8dlynhAuYq+rfK3WzEeoL oLMPsacZt+FNz++nmRWzWV6bhKM8KxOa7vhGtp1qr57gmGjydzULKXpzrQx02l2U 5jehqZkShSK3/3sbYrAH8+xTwonc2B7MmyfQKR/m7BCjRFO8W1vr51PUlGznHkWG cEFLx3iMS4VMwU6Oxz5YJDu6+iQeEMK9+vCx65po0BYTP4KVjY2WcwowtF9Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1671055355; x= 1671141755; bh=WINIwtSwe3wir98ARxc+1SeiNZ0IbhI7zwV5hmqGONk=; b=o n5G7tCLHI62FmhClAbsOaZChmUK5rLcZNcSHOBw/9ZauJyYVdzRDhShnPSH2EADI ZrQd6DXYSfnpdrLxrZ+mvFycAh/Qc8z7QJkVrJDtrdRlavOJgR5kp9kJeYDMk8wP MNAMBrt8OV7rU8Edcxqj5oSGJnxO5/WH6KbZb/zeItrBqRD8J6hIO8P0Fhn35d2R Kns4nIpBxkBZDxJSFjhEeTbIlIHn+9kSHPYre7j6SFf7HExQs8H8dE/ArTzMsZPv e85jZnHNKCVTY3m3bs1C6p/USmJ1Xrszu6N+2k46/qni28mV+n2ETHnReiV73oxl 2tiwS3XythrNm/fbX0IAA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeefgdduheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpegtgffhggfufffkfhevjgfvofesth hqmhdthhdtjeenucfhrhhomheplfhoshhtvghinhcumfhjpphnihhgshgvnhcuoehjohhs thgvihhnsehsvggtuhhrvgdrkhhjohhnihhgshgvnhdrnhgvtheqnecuggftrfgrthhtvg hrnhepjeegudevffeifeegveduieetfedtgfetgfffgeeffeeghffgfefhffeggeduvddu necuffhomhgrihhnpehkjhhnihhgshgvnhdrnhgvthenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjohhsthgvihhnsehsvggtuhhrvgdrkhhj ohhnihhgshgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Dec 2022 17:02:34 -0500 (EST) In-Reply-To: <3233F4D7-AC3A-4A99-BBDE-03693E487C9A@gmail.com> X-Mailer: iPhone Mail (20C65) Received-SPF: pass client-ip=66.111.4.26; envelope-from=jostein@secure.kjonigsen.net; helo=out2-smtp.messagingengine.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301421 Archived-At: Awesome. Thanks! =E2=80=94 Jostein Kj=C3=B8nigsen https://jostein.kj=C3=B8nigsen.net > On 14 Dec 2022, at 21:37, Yuan Fu wrote: >=20 > =EF=BB=BF >=20 >> On Dec 14, 2022, at 11:02 AM, Theodor Thornhill wrote= : >>=20 >>=20 >>=20 >>> On 14 December 2022 19:53:25 CET, "Jostein Kj=C3=B8nigsen" wrote: >>> On 14.12.2022 14:24, Randy Taylor wrote: >>>>=20 >>>> On Wednesday, December 14th, 2022 at 03:40, Jostein Kj=C3=B8nigsen wrote: >>>> Nice catch. Fixed. >>>>>=20 >>>>> Attached is a new revision. Final revision? Is this good for merging n= ow? :) >>>>>=20 >>>>> -- >>>>>=20 >>>>> Jostein >>>>>=20 >>>> Looks good to me! >>>>=20 >>> Great! Thanks for >>>=20 >>> So what's the next move from here on? Are there any other things which n= eeds to be completed before this can be merged? >>>=20 >>> I'm asking since this is my first full "original" submissions, which isn= 't a patch to an existing package/module. :) >>>=20 >>> -- >>> Jostein >>=20 >> Imo it's only missing a push :) >>=20 >> Theo >=20 > I applied and pushed it. Great work, folks! >=20 > Yuan