[PATCH] Make url-basic-auth support non-ascii passwords

[PATCH] Make url-basic-auth support non-ascii passwords

[İsmail Dönmez]

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

Hi,

url-basic-auth uses base64-encode-string but the password string can
contain non-ascii characters. In which case encode-coding-string
should be used. Attached patch fixes the issue.

Regards,
ismail

-- 
Programmer Excuse #26: I suspect it's a bus collision.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: url-basic-auth-utf8.patch --]
[-- Type: text/x-diff; name=url-basic-auth-utf8.patch, Size: 498 bytes --]

diff --git a/lisp/url/url-auth.el b/lisp/url/url-auth.el
index ce730ce..d089b18 100644
--- a/lisp/url/url-auth.el
+++ b/lisp/url/url-auth.el
@@ -93,7 +93,7 @@ instead of the filename inheritance method."
 		       (cons file
 			     (setq retval
 				   (base64-encode-string
-				    (format "%s:%s" user pass)))))
+				    (format "%s:%s" user (encode-coding-string pass 'utf-8))))))
 		 (symbol-value url-basic-auth-storage))))
      (byserv
       (setq retval (cdr-safe (assoc file byserv)))

Re: [PATCH] Make url-basic-auth support non-ascii passwords

[İsmail Dönmez]

Hi again,

On Tue, Aug 26, 2008 at 19:23, İsmail Dönmez <ismail@namtrac.org> wrote:
> url-basic-auth uses base64-encode-string but the password string can
> contain non-ascii characters. In which case encode-coding-string
> should be used. Attached patch fixes the issue.

Could someone comment on this please? It fixes twit.el authentication
problem for me.

Regards,
ismail

-- 
Programmer Excuse #16: Its a Microsoft bug.

Re: [PATCH] Make url-basic-auth support non-ascii passwords

[Stefan Monnier]

>> url-basic-auth uses base64-encode-string but the password string can
>> contain non-ascii characters. In which case encode-coding-string
>> should be used. Attached patch fixes the issue.

> Could someone comment on this please? It fixes twit.el authentication
> problem for me.

It sounds right, but I still haven't had time to get to this part of my
backlog,


        Stefan

Re: [PATCH] Make url-basic-auth support non-ascii passwords

[İsmail Dönmez]

On Fri, Aug 29, 2008 at 22:37, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>>> url-basic-auth uses base64-encode-string but the password string can
>>> contain non-ascii characters. In which case encode-coding-string
>>> should be used. Attached patch fixes the issue.
>
>> Could someone comment on this please? It fixes twit.el authentication
>> problem for me.
>
> It sounds right, but I still haven't had time to get to this part of my
> backlog,

Ping please?

Re: [PATCH] Make url-basic-auth support non-ascii passwords

[İsmail Dönmez]

On Sat, Sep 20, 2008 at 23:02, İsmail Dönmez <ismail@namtrac.org> wrote:
> On Fri, Aug 29, 2008 at 22:37, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>>>> url-basic-auth uses base64-encode-string but the password string can
>>>> contain non-ascii characters. In which case encode-coding-string
>>>> should be used. Attached patch fixes the issue.
>>
>>> Could someone comment on this please? It fixes twit.el authentication
>>> problem for me.
>>
>> It sounds right, but I still haven't had time to get to this part of my
>> backlog,
>
> Ping please?

Do we have to play ping-pong to get a simple fix installed? :) Hope not.

Regards,
ismail

[Resend] [PATCH] Make url-basic-auth support non-ascii passwords

[İsmail Dönmez]

[-- Attachment #1: Type: text/plain, Size: 576 bytes --]

Resending after nearly 2 months... Please someone review and apply this.

Thanks,
ismail


---------- Forwarded message ----------
From: İsmail Dönmez <ismail@namtrac.org>
Date: Tue, Aug 26, 2008 at 19:23
Subject: [PATCH] Make url-basic-auth support non-ascii passwords
To: emacs- devel <emacs-devel@gnu.org>


Hi,

url-basic-auth uses base64-encode-string but the password string can
contain non-ascii characters. In which case encode-coding-string
should be used. Attached patch fixes the issue.

Regards,
ismail

--
Programmer Excuse #26: I suspect it's a bus collision.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: url-basic-auth-utf8.patch --]
[-- Type: text/x-diff; name=url-basic-auth-utf8.patch, Size: 498 bytes --]

diff --git a/lisp/url/url-auth.el b/lisp/url/url-auth.el
index ce730ce..d089b18 100644
--- a/lisp/url/url-auth.el
+++ b/lisp/url/url-auth.el
@@ -93,7 +93,7 @@ instead of the filename inheritance method."
 		       (cons file
 			     (setq retval
 				   (base64-encode-string
-				    (format "%s:%s" user pass)))))
+				    (format "%s:%s" user (encode-coding-string pass 'utf-8))))))
 		 (symbol-value url-basic-auth-storage))))
      (byserv
       (setq retval (cdr-safe (assoc file byserv)))

Re: [Resend] [PATCH] Make url-basic-auth support non-ascii passwords

[Chong Yidong]

"İsmail Dönmez" <ismail@namtrac.org> writes:

> Resending after nearly 2 months... Please someone review and apply this.

Applied, thanks.


> url-basic-auth uses base64-encode-string but the password string can
> contain non-ascii characters. In which case encode-coding-string
> should be used. Attached patch fixes the issue.