From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.devel Subject: Re: master 4b98a79a50: Improve X event timestamp tracking Date: Sun, 07 Aug 2022 00:03:57 -0400 Message-ID: <19d020d85bed5d030e706800f8cbb0b7fbb3bc65.camel@dancol.org> References: <165984385935.14715.8191942019361575877@vcs2.savannah.gnu.org> <20220807034419.B5F2FC09BFD@vcs2.savannah.gnu.org> <87y1w0zpe9.fsf@yahoo.com> <87r11szp6h.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29471"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.44.1-0ubuntu1 Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 07 06:06:21 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oKXYR-0007RS-Kr for ged-emacs-devel@m.gmane-mx.org; Sun, 07 Aug 2022 06:06:20 +0200 Original-Received: from localhost ([::1]:49572 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oKXYP-0002TT-Kt for ged-emacs-devel@m.gmane-mx.org; Sun, 07 Aug 2022 00:06:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43796) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oKXWG-0001m5-2J for emacs-devel@gnu.org; Sun, 07 Aug 2022 00:04:04 -0400 Original-Received: from dancol.org ([2600:3c01:e000:3d8::1]:42294) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oKXWD-0005Nx-LV for emacs-devel@gnu.org; Sun, 07 Aug 2022 00:04:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=MIME-Version:Content-Transfer-Encoding:Content-Type:References: In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=dlXRer+Ra3NZmnHoJo2WEifacJ5T0f8OfB9mLBQwfD4=; b=m1DNhShY8vjBDEUlOTO0C6KtqJ yTIanDIMls2ilb9wyZzuKyurU7Wzd4pXXInGUf2mqAp/4PFZC2Kru7lFcV4/mt23Gg3OuLqvR1wYd 8RJsrCkfGyxtHzSJIY4qCDJvZ7l9buh3a2C3lPBEMa7dgCOicRKbHggNyS3V7guFM6gVgPMurGaah qn85+uwz59r2xRU6Sj5YMhlMY1ujl5CX/Rv09yhV63m4ICAjCZTdiTjKKAoOwkQ4h5u9OaDVEtmtt Uc9BmE1rgNTS37hGUjsRrza7Rm7wS9Wf26UzEO1z75KZk1o3N/XAjRfKl+6pCoycUcvhYa1cXSXRe i/XbNa1A==; Original-Received: from 2603-9001-4203-1ab2-640d-a545-3db0-5adc.inf6.spectrum.com ([2603:9001:4203:1ab2:640d:a545:3db0:5adc]:39134) by dancol.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oKXWB-0006ty-0s; Sat, 06 Aug 2022 21:03:59 -0700 In-Reply-To: <87r11szp6h.fsf@yahoo.com> Received-SPF: pass client-ip=2600:3c01:e000:3d8::1; envelope-from=dancol@dancol.org; helo=dancol.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:293165 Archived-At: On Sun, 2022-08-07 at 11:51 +0800, Po Lu wrote: > Daniel Colascione writes: >=20 > > You are not the sole X port maintainer. >=20 > etc/MAINTAINERS says otherwise. I've contributed code all over this project and never been limited by MAINTAINERS. This file does not grant you the authority to arbitrarily reject contributions that fix long-standing bugs. You're welcome to make improvements to committed code just like anyone else. I'd suggest minimizing friction in the future, not blocking useful work form someone who spent all day debugging this issue. > I don't buy the argument for having an entire terminal hook, meaningless > outside X (name one other window system under which it makes sense), > that is supposed to make x-focus-frame magically work in situations > where it currently does not. An "entire terminal hook" is a trivial function pointer.=C2=A0 Don't you think this is a mountain out of a molehill? What, precisely, is the resource being consumed by minimizing terminal hook structure fields?=C2=A0 Sure, we could have open-coded typecases or inscrutably invocations of some "force" parameter --- or we could make a generic terminal operation that clearly and explicitly expresses user intent. It's not as if the X event timestamp mechanism exists without reason either. Focus-stealing prevent isn't some "draconian" measure to work around or a bug in window managers, but instead a way to properly order events observed in a distributed, asynchronous system. *In general*, code is cleaner when 1) explicit programmer intent is expressed (as opposed to "add a force qualifier, because force"), and 2) that programmer intent is communicated without special cases. You're proposing scrapping a generic mechanism and replacing it with a special case, and I don't right now see the net benefit.