Re: [Emacs-diffs] master 46df7bb 03/12: Add new function time-zone-format

Re: [Emacs-diffs] master 46df7bb 03/12: Add new function time-zone-format

[Basil L. Contovounesios]

larsi@gnus.org (Lars Ingebrigtsen) writes:

> branch: master
> commit 46df7bbe12cce4c9af7ce4357aa9f8d36c1d8933
> Author: Lars Ingebrigtsen <larsi@gnus.org>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>
>     Add new function time-zone-format
>     

[...]

> +(defun time-zone-format (seconds)
> +  "Format SECONDS as a valid time zone string.
> +For instance, 3600 is \"+01:00\"."
> +  (format "%s%02d:%02d"
> +          (if (< seconds 0)
> +              "-"
> +            "+")
> +          (/ (abs seconds) 3600)
> +          (mod (abs seconds) 3600)))
> +

Can't this (and its extension in a subsequent commit) be written in
terms of, or replaced by, format-time-string?

(format-time-string "%:z" nil  3600) ; => "+01:00"
(format-time-string "%:z" nil -7200) ; => "-02:00"
(format-time-string "%z"  nil  3600) ; => "+0100"
(format-time-string "%z"  nil -7200) ; => "-0200"

Thanks,

-- 
Basil

Re: [Emacs-diffs] master 46df7bb 03/12: Add new function time-zone-format

[Paul Eggert]

Basil L. Contovounesios wrote:
> Can't this (and its extension in a subsequent commit) be written in
> terms of, or replaced by, format-time-string?

Right you are. I replaced (time-zone-format zone t) with (format-time-string 
"%z" nil zone). It's not clear we need a separate time-zone-format function so I 
undid that for now.