all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: David PONCE <david.ponce@wanadoo.fr>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Consolidation of image support in new image.c file.
Date: Fri, 12 Mar 2004 11:46:57 +0100 (CET)	[thread overview]
Message-ID: <1994019.1079088417309.JavaMail.www@wwinf1003> (raw)

Hi Kim,

Following your change to consolidate image support I had to apply this
patch to fix a link error when building Emacs "--with-gtk".

This is because in that case the function `xg_set_icon' in xfns.c
calls `x_find_image_file' which is now in image.c

Hope it helps.

Sincerely,
David

Index: src/dispextern.h
===================================================================
RCS file: /cvsroot/emacs/emacs/src/dispextern.h,v
retrieving revision 1.168
diff -c -r1.168 dispextern.h
*** src/dispextern.h	11 Mar 2004 22:42:47 -0000	1.168
--- src/dispextern.h	12 Mar 2004 10:29:46 -0000
***************
*** 2618,2624 ****
  #endif
  extern void x_destroy_all_bitmaps P_ ((Display_Info *));
  extern int x_create_bitmap_mask P_ ((struct frame * , int));
! 
  void x_kill_gs_process P_ ((Pixmap, struct frame *));
  struct image_cache *make_image_cache P_ ((void));
  void free_image_cache P_ ((struct frame *));
--- 2618,2624 ----
  #endif
  extern void x_destroy_all_bitmaps P_ ((Display_Info *));
  extern int x_create_bitmap_mask P_ ((struct frame * , int));
! extern Lisp_Object x_find_image_file P_ ((Lisp_Object));
  void x_kill_gs_process P_ ((Pixmap, struct frame *));
  struct image_cache *make_image_cache P_ ((void));
  void free_image_cache P_ ((struct frame *));
Index: src/image.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/image.c,v
retrieving revision 1.4
diff -c -r1.4 image.c
*** src/image.c	11 Mar 2004 22:43:06 -0000	1.4
--- src/image.c	12 Mar 2004 10:29:46 -0000
***************
*** 1998,2004 ****
  			      File Handling
   ***********************************************************************/
  
- static Lisp_Object x_find_image_file P_ ((Lisp_Object));
  static unsigned char *slurp_file P_ ((char *, int *));
  
  
--- 1998,2003 ----
***************
*** 2006,2012 ****
     x-bitmap-file-path.  Value is the full name of the file found, or
     nil if not found.  */
  
! static Lisp_Object
  x_find_image_file (file)
       Lisp_Object file;
  {
--- 2005,2011 ----
     x-bitmap-file-path.  Value is the full name of the file found, or
     nil if not found.  */
  
! Lisp_Object
  x_find_image_file (file)
       Lisp_Object file;
  {
Index: src/xfns.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/xfns.c,v
retrieving revision 1.607
diff -c -r1.607 xfns.c
*** src/xfns.c	11 Mar 2004 00:25:38 -0000	1.607
--- src/xfns.c	12 Mar 2004 10:29:47 -0000
***************
*** 761,768 ****
  
  #ifdef USE_GTK
  
- static Lisp_Object x_find_image_file P_ ((Lisp_Object file));
- 
  /* Set icon from FILE for frame F.  By using GTK functions the icon
     may be any format that GdkPixbuf knows about, i.e. not just bitmaps.  */
  
--- 761,766 ----

             reply	other threads:[~2004-03-12 10:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-12 10:46 David PONCE [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-03-11  1:40 Consolidation of image support in new image.c file Kim F. Storm
2004-03-11  1:14 ` Luc Teirlinck
2004-03-11 12:25   ` Kim F. Storm
2004-03-11  5:57 ` Steven Tamm
2004-03-11 12:25   ` Kim F. Storm
2004-03-11 22:16   ` YAMAMOTO Mitsuharu
2004-03-11 23:52     ` Kim F. Storm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1994019.1079088417309.JavaMail.www@wwinf1003 \
    --to=david.ponce@wanadoo.fr \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.