all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: David Reitter <dreitter@inf.ed.ac.uk>
To: emacs- devel <emacs-devel@gnu.org>
Subject: saveplace: don't ask for coding system
Date: Wed, 28 Nov 2007 14:46:08 +0000	[thread overview]
Message-ID: <198E2B70-D060-41D8-8BC2-A9614C2729CC@inf.ed.ac.uk> (raw)

Can I suggest the following two changes to saveplace.el?

- set the coding system so that the user isn't asked about a coding  
system for the places file every time they quit Emacs (when file names  
contain non-standard characters).

- do not show a message about saving - it's not useful information for  
most users and contributes to information overload!
   (if the function was interactive, this would be a different story.)


I have no write access to CVS, so if people like such changes,  
somebody will have to commit them.



*** lisp/saveplace.el	25 Jul 2007 05:47:04 +0100	1.37.2.1
--- lisp/saveplace.el	28 Nov 2007 14:40:39 +0000	
***************
*** 207,213 ****
   (defun save-place-alist-to-file ()
     (let ((file (expand-file-name save-place-file)))
       (save-excursion
!       (message "Saving places to %s..." file)
         (set-buffer (get-buffer-create " *Saved Places*"))
         (delete-region (point-min) (point-max))
         (when save-place-forget-unreadable-files
--- 207,213 ----
   (defun save-place-alist-to-file ()
     (let ((file (expand-file-name save-place-file)))
       (save-excursion
!       ;; (message "Saving places to %s..." file)
         (set-buffer (get-buffer-create " *Saved Places*"))
         (delete-region (point-min) (point-max))
         (when save-place-forget-unreadable-files
***************
*** 224,233 ****
                  t))))
   	(condition-case nil
   	    ;; Don't use write-file; we don't want this buffer to visit it.
! 	    (write-region (point-min) (point-max) file)
! 	  (file-error (message "Can't write %s" file)))
           (kill-buffer (current-buffer))
!         (message "Saving places to %s...done" file)))))

   (defun load-save-place-alist-from-file ()
     (if (not save-place-loaded)
--- 224,235 ----
                  t))))
   	(condition-case nil
   	    ;; Don't use write-file; we don't want this buffer to visit it.
! 	    (let ((coding-system-for-write 'utf-8))
! 	      (write-region (point-min) (point-max) file))
! 	  (file-error (message "Saving places: Can't write %s" file)))
           (kill-buffer (current-buffer))
!         ;;(message "Saving places to %s...done" file)
! 	))))

   (defun load-save-place-alist-from-file ()
     (if (not save-place-loaded)

             reply	other threads:[~2007-11-28 14:46 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-28 14:46 David Reitter [this message]
2007-11-28 21:47 ` saveplace: don't ask for coding system Eli Zaretskii
2007-11-29  0:25   ` David Reitter
2007-12-03  1:04     ` General variable for verbosity level. (was: saveplace: don't ask for coding system) Karl Fogel
2007-12-03 20:22       ` David Reitter
2007-12-03 21:44         ` General variable for verbosity level Karl Fogel
2007-12-03 22:34       ` Reiner Steib
2007-11-29  9:04   ` saveplace: don't ask for coding system Juanma Barranquero
2007-11-29 21:04     ` Eli Zaretskii
2007-11-30  9:17       ` Juanma Barranquero
2007-11-29  9:05 ` Juanma Barranquero
2007-12-02 16:51   ` David Reitter
2007-12-02 21:26     ` Karl Fogel
2007-12-02 21:31       ` David Reitter
2007-12-02 23:23         ` Karl Fogel
2007-12-03  4:18           ` Eli Zaretskii
2007-12-03 10:59             ` Karl Fogel
2007-12-03 11:06               ` Juanma Barranquero
2007-12-03 21:02                 ` Stephen J. Turnbull
2007-12-03 20:48               ` Eli Zaretskii
2007-12-03 21:32                 ` Karl Fogel
2007-12-04  4:20                   ` Eli Zaretskii
2007-12-04  6:17                     ` Karl Fogel
2007-12-04 20:57                       ` Eli Zaretskii
2007-12-04 16:40                     ` Juanma Barranquero
2007-12-04 21:32                       ` Eli Zaretskii
2007-12-04 22:24                         ` Stefan Monnier
2007-12-05  4:52                           ` Eli Zaretskii
2007-12-05  8:49                             ` Juanma Barranquero
2007-12-05 18:25                               ` Eli Zaretskii
2007-12-05 20:05                                 ` Juanma Barranquero
2007-12-06  4:21                                   ` Eli Zaretskii
2007-12-06 12:38                                     ` Juanma Barranquero
2007-12-04 22:51                         ` Juanma Barranquero
2007-12-04 16:55                   ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=198E2B70-D060-41D8-8BC2-A9614C2729CC@inf.ed.ac.uk \
    --to=dreitter@inf.ed.ac.uk \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.