From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ulrich Mueller Newsgroups: gmane.emacs.bugs Subject: bug#8302: 23.3; Parallel make: some *.el files are byte-compiled twice Date: Sun, 20 Mar 2011 21:26:48 +0100 Message-ID: <19846.25352.41735.981075@a1i15.kph.uni-mainz.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----cutting-here-may-damage-your-screen-surface----87198202----" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1300653541 1679 80.91.229.12 (20 Mar 2011 20:39:01 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 20 Mar 2011 20:39:01 +0000 (UTC) To: 8302@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 20 21:38:56 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q1POn-0005um-Lw for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Mar 2011 21:38:54 +0100 Original-Received: from localhost ([127.0.0.1]:33781 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q1POn-0001Sp-7A for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Mar 2011 16:38:53 -0400 Original-Received: from [140.186.70.92] (port=34820 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q1PN2-0000Zg-P2 for bug-gnu-emacs@gnu.org; Sun, 20 Mar 2011 16:37:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q1PN1-0005K3-9j for bug-gnu-emacs@gnu.org; Sun, 20 Mar 2011 16:37:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55686) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q1PN1-0005Jx-7w for bug-gnu-emacs@gnu.org; Sun, 20 Mar 2011 16:37:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Q1PEH-0005uQ-OT; Sun, 20 Mar 2011 16:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ulrich Mueller Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Mar 2011 20:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 8302 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.130065283622661 (code B ref -1); Sun, 20 Mar 2011 20:28:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 20 Mar 2011 20:27:16 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q1PDX-0005tR-Jw for submit@debbugs.gnu.org; Sun, 20 Mar 2011 16:27:16 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q1PDV-0005tE-AK for submit@debbugs.gnu.org; Sun, 20 Mar 2011 16:27:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q1PDO-00042b-Vv for submit@debbugs.gnu.org; Sun, 20 Mar 2011 16:27:08 -0400 Original-Received: from lists.gnu.org ([199.232.76.165]:42880) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q1PDO-00042X-TO for submit@debbugs.gnu.org; Sun, 20 Mar 2011 16:27:06 -0400 Original-Received: from [140.186.70.92] (port=47508 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q1PDN-0007E0-FZ for bug-gnu-emacs@gnu.org; Sun, 20 Mar 2011 16:27:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q1PDL-00041u-RK for bug-gnu-emacs@gnu.org; Sun, 20 Mar 2011 16:27:05 -0400 Original-Received: from a1iwww1.kph.uni-mainz.de ([134.93.134.1]:45224) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q1PDL-00040i-JS for bug-gnu-emacs@gnu.org; Sun, 20 Mar 2011 16:27:03 -0400 Original-Received: from a1i15.kph.uni-mainz.de (a1i15.kph.uni-mainz.de [134.93.134.92]) by a1iwww1.kph.uni-mainz.de (8.14.0/8.13.4) with ESMTP id p2KKQmbL028521 for ; Sun, 20 Mar 2011 21:26:48 +0100 Original-Received: from a1i15.kph.uni-mainz.de (localhost [127.0.0.1]) by a1i15.kph.uni-mainz.de (8.14.4/8.14.2) with ESMTP id p2KKQmQO021266; Sun, 20 Mar 2011 21:26:48 +0100 Original-Received: (from ulm@localhost) by a1i15.kph.uni-mainz.de (8.14.4/8.14.4/Submit) id p2KKQmhm021265; Sun, 20 Mar 2011 21:26:48 +0100 X-Mailer: VM 8.1.1 under 23.3.1 (x86_64-pc-linux-gnu) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 20 Mar 2011 16:28:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:45206 Archived-At: ------cutting-here-may-damage-your-screen-surface----87198202---- Content-Type: text/plain; charset=us-ascii Content-Description: message body text Content-Transfer-Encoding: 7bit Tags: patch With parallel make (-j3), some elisp files, for example lisp/select.el and lisp/scroll-bar.el, are byte-compiled twice. From the build log: Compiling /var/tmp/portage/app-editors/emacs-23.3/work/emacs-23.3/src/../lisp/select.el [...] Wrote /var/tmp/portage/app-editors/emacs-23.3/work/emacs-23.3/lisp/select.elc [...] Compiling ../lisp/select.el [...] Wrote /var/tmp/portage/app-editors/emacs-23.3/work/emacs-23.3/lisp/select.elc The reason seems to be that select.elc occurs twice in src/Makefile.in: in variable "lisp" as $(lispsource)select.elc and in variable "SOME_MACHINE_LISP" as ../lisp/select.elc, so that make doesn't recognise them as identical targets. Attached patch makes the problem go away for me. My humble solution is to change SOME_MACHINE_LISP to use $(lispsource), and introduce a new variable SOME_MACHINE_SHORTLISP for the ../lisp/ entries. (Quite the same as for the lisp and shortlisp variables). As a side remark, mouse.elc is listed twice in the variable assignment. Attached patch fixes this too. ------cutting-here-may-damage-your-screen-surface----87198202---- Content-Type: text/plain; name="emacs-23.3-parallel-make.patch" Content-Disposition: inline; filename="emacs-23.3-parallel-make.patch" Content-Transfer-Encoding: 7bit --- emacs-23.3-orig/src/Makefile.in +++ emacs-23.3/src/Makefile.in @@ -887,9 +887,26 @@ ../lisp/window.elc \ ../lisp/version.el +SOME_MACHINE_LISP = $(lispsource)mouse.elc \ + $(lispsource)select.elc $(lispsource)scroll-bar.elc \ + $(lispsource)ls-lisp.elc $(lispsource)dos-fns.elc \ + $(lispsource)w32-fns.elc $(lispsource)dos-w32.elc \ + $(lispsource)disp-table.elc $(lispsource)dos-vars.elc \ + $(lispsource)tooltip.elc $(lispsource)image.elc \ + $(lispsource)fringe.elc $(lispsource)dnd.elc \ + $(lispsource)mwheel.elc $(lispsource)tool-bar.elc \ + $(lispsource)x-dnd.elc $(lispsource)font-setting.elc \ + $(lispsource)international/ccl.elc \ + $(lispsource)international/fontset.elc \ + $(lispsource)term/common-win.elc \ + $(lispsource)term/x-win.elc \ + $(lispsource)term/pc-win.elc $(lispsource)term/internal.elc \ + $(lispsource)term/ns-win.elc $(lispsource)term/w32-win.elc \ + $(lispsource)emacs-lisp/easymenu.elc + /* Like $shortlisp, but includes only those files from $lisp that are loaded conditionally (i.e., only on some platforms). */ -SOME_MACHINE_LISP = ../lisp/mouse.elc \ +SOME_MACHINE_SHORTLISP = ../lisp/mouse.elc \ ../lisp/select.elc ../lisp/scroll-bar.elc \ ../lisp/ls-lisp.elc ../lisp/dos-fns.elc \ ../lisp/w32-fns.elc ../lisp/dos-w32.elc \ @@ -900,7 +917,6 @@ ../lisp/x-dnd.elc ../lisp/font-setting.elc \ ../lisp/international/ccl.elc \ ../lisp/international/fontset.elc \ - ../lisp/mouse.elc \ ../lisp/term/common-win.elc \ ../lisp/term/x-win.elc \ ../lisp/term/pc-win.elc ../lisp/term/internal.elc \ @@ -955,7 +971,7 @@ ${etc}DOC: ${libsrc}make-docfile${EXEEXT} ${obj} ${lisp} ${SOME_MACHINE_LISP} -rm -f ${etc}DOC ${libsrc}make-docfile -d ${srcdir} ${SOME_MACHINE_OBJECTS} ${obj} > ${etc}DOC - ${libsrc}make-docfile -a ${etc}DOC -d ${srcdir} ${SOME_MACHINE_LISP} ${shortlisp} + ${libsrc}make-docfile -a ${etc}DOC -d ${srcdir} ${SOME_MACHINE_SHORTLISP} ${shortlisp} ${libsrc}make-docfile${EXEEXT}: cd ${libsrc}; ${MAKE} ${MFLAGS} make-docfile${EXEEXT} ------cutting-here-may-damage-your-screen-surface----87198202------