From: Eric Swenson <eric@swenson.org>
To: Juri Linkov <juri@linkov.net>, Eli Zaretskii <eliz@gnu.org>
Cc: 55070@debbugs.gnu.org, larsi@gnus.org
Subject: bug#55070: 28.1; desktop-load doesn't work in -nw (non-gui) emacs
Date: Wed, 27 Apr 2022 10:02:09 -0700 [thread overview]
Message-ID: <19755688-1BC3-45A0-854D-031469E50DB9@swenson.org> (raw)
In-Reply-To: <86fslysc14.fsf@mail.linkov.net>
Did you provide another patch, Juri? Or is it the same one you provided yesterday in this thread? -- Eric
On 4/27/22, 9:57 AM, "Juri Linkov" <juri@linkov.net> wrote:
tags 55070 + patch
quit
>> >> ;; People don't expect emacs -nw, or --daemon,
>> >> ;; to create graphical frames (bug#17693).
>> >> ;; TODO perhaps there should be a separate value
>> >> ;; for desktop-restore-frames to control this startup behavior?
>> >>
>> >> So this patch creates such separate values:
>> >
>> > Thanks, but I don't understand why you need the frameset part of the
>> > patch.
>>
>> Because restoring frames on tty fails without this fix.
>
> Restoring frames is desktop.el's business, so it should be fixed
> there.
The sole purpose of frameset.el is to save and restore frames.
So the bug was fixed in frameset.el.
> Why does "emacs -nw" at all save frame coordinates if they
> cannot be restored?
"emacs -nw" doesn't save frame coordinates.
>> > Or if you do need it, why does it have to look so ad-hoc? If
>> > we want to support in frameset.el frames for which some frame
>> > parameters make no sense, let's do that explicitly, not by sweeping
>> > problems under the carpet by substituting some arbitrary values for
>> > those parameters that give us trouble.
>>
>> These values are not arbitrary. The function frame-monitor-attributes
>> used in the same fixed function frameset-move-onscreen returns on tty:
>>
>> ((geometry 0 0 80 23)
>> (workarea 0 0 80 23))
>>
>> where 'left' and 'top' values are zero.
>
> That is arbitrary as well.
>
> I hope we can find a more elegant and explicit solution to this issue.
I provided the patch to fix this bug.
If you know how to fix it better, this would be fine.
next prev parent reply other threads:[~2022-04-27 17:02 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 23:27 bug#55070: 28.1; desktop-load doesn't work in -nw (non-gui) emacs Eric Swenson
2022-04-23 6:13 ` Eli Zaretskii
2022-04-23 13:52 ` Eric Swenson
2022-04-23 14:25 ` Eli Zaretskii
2022-04-23 14:53 ` Eric Swenson
2022-04-23 15:16 ` Eli Zaretskii
2022-04-23 15:39 ` Eric Swenson
2022-04-26 7:58 ` Juri Linkov
2022-04-26 10:16 ` Lars Ingebrigtsen
2022-04-26 11:26 ` Eli Zaretskii
2022-04-26 15:28 ` Juri Linkov
2022-04-26 16:09 ` Eli Zaretskii
2022-04-26 17:40 ` Juri Linkov
2022-04-26 18:14 ` Eli Zaretskii
2022-04-27 16:53 ` Juri Linkov
2022-04-27 17:02 ` Eric Swenson [this message]
2022-04-28 7:01 ` Juri Linkov
2022-04-28 16:18 ` Eric Swenson
2022-04-28 17:39 ` Juri Linkov
2022-04-30 8:42 ` Eli Zaretskii
2022-05-01 17:25 ` Juri Linkov
2022-05-03 16:31 ` Eli Zaretskii
2022-05-03 17:57 ` Juri Linkov
2022-05-03 18:28 ` Eli Zaretskii
2022-05-05 16:35 ` Juri Linkov
2022-05-05 16:51 ` Eli Zaretskii
2022-05-05 18:08 ` Juri Linkov
2022-04-27 17:16 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19755688-1BC3-45A0-854D-031469E50DB9@swenson.org \
--to=eric@swenson.org \
--cc=55070@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=juri@linkov.net \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.