From: Ulrich Mueller <ulm@gentoo.org>
To: 7717@debbugs.gnu.org
Subject: bug#7717: 24.0.50; "games" user is hardcoded in build system
Date: Thu, 23 Dec 2010 09:36:42 +0100 [thread overview]
Message-ID: <19731.2586.417212.58988@a1i15.kph.uni-mainz.de> (raw)
[-- Attachment #1: message body text --]
[-- Type: text/plain, Size: 492 bytes --]
Tags: patch
The build system of Emacs currently hardcodes the "games" user that is
used for shared score files in ${localstatedir}. While usage of that
account name may be widespread, it is not universal. For example, in
Gentoo the name is configurable.
Since a variable "gameuser" and the autoconf plumbing for it already
exist, the only missing piece is a configure option. See attached
patch.
2010-12-22 Ulrich Mueller <ulm@gentoo.org>
* configure.in: Make gameuser configurable.
[-- Attachment #2: emacs-gameuser.diff --]
[-- Type: text/plain, Size: 963 bytes --]
--- emacs-orig/configure.in
+++ emacs/configure.in
@@ -45,8 +45,6 @@
docdir='${datadir}/emacs/${version}/etc'
gamedir='${localstatedir}/games/emacs'
-gameuser=games
-
dnl OPTION_DEFAULT_OFF(NAME, HELP-STRING)
dnl Create a new --with option that defaults to being disabled.
dnl NAME is the base name of the option. The shell variable with_NAME
@@ -203,6 +201,13 @@
The default is /usr/lib, or /usr/lib64 on some platforms.])])
CRT_DIR="${with_crt_dir}"
+AC_ARG_WITH(gameuser,
+[AS_HELP_STRING([--with-gameuser=USER],
+ [user for shared score files; default games])])
+test "X${with_gameuser}" != X && test "${with_gameuser}" != yes \
+ && gameuser="${with_gameuser}"
+test "X$gameuser" = X && gameuser=games
+
AC_ARG_WITH([gnustep-conf],dnl
[AS_HELP_STRING([--with-gnustep-conf=PATH],[path to GNUstep.conf; default $GNUSTEP_CONFIG_FILE, or /etc/GNUstep/GNUstep.conf])])
test "X${with_gnustep_conf}" != X && test "${with_gnustep_conf}" != yes && \
next reply other threads:[~2010-12-23 8:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-23 8:36 Ulrich Mueller [this message]
2010-12-29 11:14 ` bug#7717: 24.0.50; "games" user is hardcoded in build system Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19731.2586.417212.58988@a1i15.kph.uni-mainz.de \
--to=ulm@gentoo.org \
--cc=7717@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.