all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Bob Rogers <rogers-emacs@rgrjr.dyndns.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Updating *vc-dir* marks from *VC-log*
Date: Sun, 21 Nov 2010 15:46:05 -0500	[thread overview]
Message-ID: <19689.34061.22358.70758@rgr.rgrjr.com> (raw)
In-Reply-To: <jwvoc9iy136.fsf-monnier+emacs@gnu.org>

   From: Stefan Monnier <monnier@iro.umontreal.ca>
   Date: Sun, 21 Nov 2010 13:43:19 -0500

   >    Perhaps I'm slow, but I only just noticed that it is possible to work
   > on multiple VC commits for the same working copy in parallel, just by
   > renaming *VC-log* buffers.  This is cool; it perfectly suits my working
   > style.  I would like to write it up for the Emacs manual so that others
   > can find it.

   Hmm... I'd like to change VC-Log so that it always commits what's
   selected in vc-dir at the time of the commit rather than at the time the
   VC-Log buffer is opened (with a confirmation prompt to the user when the
   two sets are actually different).

Yes, that's what I thought you meant.  (But I was thinking of going
further, such that if the user refuses the "Use new fileset?" prompt,
there is a followup "Commit current fileset?" prompt.  That preserves
access to existing behavior, though it does make an exception to the
"always commits" rule you have stated.)

   In the common case where the user only uses a single VC-Log buffer, it
   is better than the current situation since it makes your
   log-edit-visit-files-in-vc-dir completely unnecessary.

That is mostly true.  The difference is that
log-edit-visit-files-in-vc-dir also works to change the fileset of a
commit that starts from a single file.  You can use vc-dir for that
purpose by doing an explicit C-x v v in *vc-dir* to hijack the existing
single-file log buffer, but that is not obvious.  And if the user
doesn't C-x v v from *vc-dir*, then C-c C-c won't DTRT, because it won't
know about *vc-dir*.

   And it would also be convenient to have a log-edit-mode command that
takes you back to the right *vc-dir* buffer.  Of course, that's a much
simpler command than log-edit-visit-files-in-vc-dir.  Would that be
preferable?

   But I'm not sure how to best handle your use case where you have several
   VC-Log buffers, then.

	   Stefan

Then perhaps we should table this discussion until the "Use new
fileset?" prompt is in place.

					-- Bob



      reply	other threads:[~2010-11-21 20:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-21  0:58 Updating *vc-dir* marks from *VC-log* Bob Rogers
2010-11-21  4:46 ` Dan Nicolaescu
2010-11-21 16:14   ` Bob Rogers
2010-11-21 17:02     ` Dan Nicolaescu
2010-11-21 18:30       ` Bob Rogers
2010-11-23 17:06         ` Dan Nicolaescu
2010-11-21 18:43 ` Stefan Monnier
2010-11-21 20:46   ` Bob Rogers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19689.34061.22358.70758@rgr.rgrjr.com \
    --to=rogers-emacs@rgrjr.dyndns.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.