From: Bob Rogers <rogers-emacs@rgrjr.dyndns.org>
To: Dan Nicolaescu <dann@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Updating *vc-dir* marks from *VC-log*
Date: Sun, 21 Nov 2010 11:14:04 -0500 [thread overview]
Message-ID: <19689.17740.876119.178798@rgr.rgrjr.com> (raw)
In-Reply-To: <yxq4obbthan.fsf@fencepost.gnu.org>
From: Dan Nicolaescu <dann@gnu.org>
Date: Sat, 20 Nov 2010 23:46:40 -0500
Bob Rogers <rogers-emacs@rgrjr.dyndns.org> writes:
> . . . With multiple pending commits, what is needed is a way to return
> to vc-dir and "swap in" the log buffer fileset. The patch below adds a
> new log-edit-visit-files-in-vc-dir command to do this. I have
> tentatively bound it to "C-c @" in log-edit-mode, which I hope is
> sufficiently mnemonic for "mark".
I am not sure what you are trying to do here...
In the *VC log* buffer the vc-parent-buffer buffer-local variable
points to the *vc dir* buffer that was used to create it.
Doesn't this simplify what you are trying to do?
Hmm. It could conceivably make vc-dir-find-buffer-for-file unnecessary.
(I had written that for another hack where vc-parent-buffer may not be
defined, or may not point to a vc-dir buffer, and just used it
unthinkingly here.)
On the other hand, one would have to assume that users only want to
adjust the filesets of commits started from vc-dir buffers.
vc-dir-find-buffer-for-file would still be useful if the user originally
typed "C-x v v" in a file buffer, and then had second thoughts.
But, at the very least, I ought to check vc-parent-buffer first,
since that would always DTRT if the file appears in multiple vc-dir
buffers. Thanks for making that apparent.
BTW, this is a subproject that came up while trying to make Emacs
smarter about changing marked files in vc-dir during the commit (see
bug#7350). If the user does that, then Emacs should (a) ask her if she
wants to update the fileset if she types C-c C-c in the log buffer, and
(b) ask her if she wants to start a new commit or update the old one if
she types C-x v v in the vc-dir buffer. Both of those involve updating
the fileset of an existing log buffer, so I probably need to address
that first.
-- Bob
next prev parent reply other threads:[~2010-11-21 16:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-21 0:58 Updating *vc-dir* marks from *VC-log* Bob Rogers
2010-11-21 4:46 ` Dan Nicolaescu
2010-11-21 16:14 ` Bob Rogers [this message]
2010-11-21 17:02 ` Dan Nicolaescu
2010-11-21 18:30 ` Bob Rogers
2010-11-23 17:06 ` Dan Nicolaescu
2010-11-21 18:43 ` Stefan Monnier
2010-11-21 20:46 ` Bob Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19689.17740.876119.178798@rgr.rgrjr.com \
--to=rogers-emacs@rgrjr.dyndns.org \
--cc=dann@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.