From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bob Rogers Newsgroups: gmane.emacs.bugs Subject: bug#7350: 24.0.50; make vc-deduce-backend smarter Date: Thu, 18 Nov 2010 21:27:19 -0500 Message-ID: <19685.57479.436724.154495@rgr.rgrjr.com> References: <19669.54304.980911.220632@rgr.rgrjr.com> <19671.7412.608640.593137@rgr.rgrjr.com> <19672.26151.150217.308712@rgr.rgrjr.com> <19680.28414.314610.707478@rgr.rgrjr.com> <19683.23940.23038.507387@rgr.rgrjr.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1290134671 17345 80.91.229.12 (19 Nov 2010 02:44:31 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 19 Nov 2010 02:44:31 +0000 (UTC) Cc: 7350@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 19 03:44:27 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PJGxe-0000KT-LG for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 Nov 2010 03:44:26 +0100 Original-Received: from localhost ([127.0.0.1]:55577 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PJGxe-0003D4-8U for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Nov 2010 21:44:26 -0500 Original-Received: from [140.186.70.92] (port=36448 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PJGxZ-0003Cl-ST for bug-gnu-emacs@gnu.org; Thu, 18 Nov 2010 21:44:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PJGxY-0002rr-IG for bug-gnu-emacs@gnu.org; Thu, 18 Nov 2010 21:44:21 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35470) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PJGxY-0002rb-Gh for bug-gnu-emacs@gnu.org; Thu, 18 Nov 2010 21:44:20 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PJGcw-0000gf-JT; Thu, 18 Nov 2010 21:23:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Bob Rogers Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Nov 2010 02:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7350 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7350-submit@debbugs.gnu.org id=B7350.12901333522632 (code B ref 7350); Fri, 19 Nov 2010 02:23:02 +0000 Original-Received: (at 7350) by debbugs.gnu.org; 19 Nov 2010 02:22:32 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PJGcR-0000gP-Va for submit@debbugs.gnu.org; Thu, 18 Nov 2010 21:22:32 -0500 Original-Received: from rgrjr.com ([216.146.47.5]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PJGcB-0000gK-KP for 7350@debbugs.gnu.org; Thu, 18 Nov 2010 21:22:30 -0500 Original-Received: from rgrjr.dyndns.org (c-66-30-196-77.hsd1.ma.comcast.net [66.30.196.77]) by rgrjr.com (Postfix on CentOS) with ESMTP id 1802A160169 for <7350@debbugs.gnu.org>; Fri, 19 Nov 2010 02:27:21 +0000 (UTC) Original-Received: (qmail 26249 invoked by uid 89); 19 Nov 2010 02:27:20 -0000 Original-Received: from unknown (HELO rgr.rgrjr.com) (192.168.57.1) by home with SMTP; 19 Nov 2010 02:27:20 -0000 Original-Received: by rgr.rgrjr.com (Postfix, from userid 500) id E80A1A4E6E; Thu, 18 Nov 2010 21:27:19 -0500 (EST) In-Reply-To: X-Mailer: VM 7.19 under Emacs 24.0.50.1 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 18 Nov 2010 21:23:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:41744 Archived-At: From: Stefan Monnier Date: Wed, 17 Nov 2010 08:31:26 -0500 > Grepping found only one caller; vc-log-edit passes it as the > log-edit-diff-function. But this really ought to use the passed > fileset, and not go through the command again, true? Actually, what it *should* do is select the same fileset as the one that C-c C-c will commit. Yes, exactly. I'm not sure which fileset is chosen by C-c C-c, but if I were to choose, I'd follow the PCL-CVS behavior which is to recompute the fileset rather than use whatever was the fileset when the *VC-Log* buffer was created . . . The fileset is not recomputed; if you change the fileset in *vc-dir*, you must do vc-next-action explicitly to update the log buffer fileset. That threw me for a loop when I first used it, but now that I've gotten used to it, I can see the utility of it. (but aditionally check whether the new fileset is the same as the old one, and if not prompt the user to make sure that's really what she intended). Stefan Sounds like a clear win, since it removes the confusingness while continuing to allow both behaviors. Accordingly, that ought to get fixed first. If I come up with a reasonable patch, I'll file a new bug report. -- Bob