From: "Chong Yidong" <cyd@stupidchicken.com>
Subject: Problem with modeline and window margins
Date: Thu, 20 Jan 2005 05:41:14 -0500 (EST) [thread overview]
Message-ID: <1957.220.255.79.102.1106217674.squirrel@220.255.79.102> (raw)
Regarding the following item from FOR_RELEASE:
> ** Problem with modeline and window margins:
>
> The mode line's right "box" line is misplaced under the right margin,
> rather than at the right window edge.
>
> emacs -Q
> (set-window-margins nil 25 25)
> C-x 2
The problem seems to be that x_draw_glyph_string_box finds the right-hand
edge of the box by calling window_box_right. However, the value returned
by window_box_right stops at the right margin (see the definition of
window_box_width.)
The following patch for xterm.c seems to fix the bug, but someone ought to
check it. The corresponding patches for w32term.c and macterm.c are
straightforward.
--- xterm.c Thu Jan 20 18:37:15 2005
+++ xterm.c~ Thu Jan 20 18:26:16 2005
@@ -2131,18 +2131,14 @@
if (s->row->full_width_p
&& !s->w->pseudo_window_p)
{
last_x += WINDOW_RIGHT_SCROLL_BAR_AREA_WIDTH (s->w);
if (s->area != RIGHT_MARGIN_AREA
|| WINDOW_HAS_FRINGES_OUTSIDE_MARGINS (s->w))
last_x += WINDOW_RIGHT_FRINGE_WIDTH (s->w);
- /* window_box_right excludes the right margin, so we add it. */
- if (INTEGERP (s->w->right_margin_cols))
- last_x += XFASTINT (s->w->left_margin_cols)
- * WINDOW_FRAME_COLUMN_WIDTH (s->w);
}
/* The glyph that may have a right box line. */
last_glyph = (s->cmp || s->img
? s->first_glyph
: s->first_glyph + s->nchars - 1);
next reply other threads:[~2005-01-20 10:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-20 10:41 Chong Yidong [this message]
2005-01-20 13:06 ` Problem with modeline and window margins Kim F. Storm
2005-01-20 14:42 ` Chong Yidong
2005-01-21 20:09 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1957.220.255.79.102.1106217674.squirrel@220.255.79.102 \
--to=cyd@stupidchicken.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.