From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: rogers-emacs@rgrjr.dyndns.org Newsgroups: gmane.emacs.bugs Subject: bug#6870: Make vc-root-diff work in more modes Date: Mon, 16 Aug 2010 21:55:39 -0400 Message-ID: <19561.60443.364109.899857@rgr.rgrjr.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1282010950 11587 80.91.229.12 (17 Aug 2010 02:09:10 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 17 Aug 2010 02:09:10 +0000 (UTC) To: 6870@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 17 04:09:08 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OlBbr-0000Xj-TQ for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Aug 2010 04:09:04 +0200 Original-Received: from localhost ([127.0.0.1]:58334 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OlBbr-00066Q-8x for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Aug 2010 22:09:03 -0400 Original-Received: from [140.186.70.92] (port=37262 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OlBbj-00065K-QX for bug-gnu-emacs@gnu.org; Mon, 16 Aug 2010 22:08:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OlBbi-00048X-Hx for bug-gnu-emacs@gnu.org; Mon, 16 Aug 2010 22:08:55 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53778) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OlBbi-00048T-En for bug-gnu-emacs@gnu.org; Mon, 16 Aug 2010 22:08:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OlBOI-00089F-6t; Mon, 16 Aug 2010 21:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: rogers-emacs@rgrjr.dyndns.org Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Aug 2010 01:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 6870 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.128201008831313 (code B ref -1); Tue, 17 Aug 2010 01:55:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 17 Aug 2010 01:54:48 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OlBO3-000890-Ug for submit@debbugs.gnu.org; Mon, 16 Aug 2010 21:54:48 -0400 Original-Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OlBO2-00088v-4Y for submit@debbugs.gnu.org; Mon, 16 Aug 2010 21:54:46 -0400 Original-Received: from lists.gnu.org ([199.232.76.165]:42119) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OlBP1-00075V-3d for submit@debbugs.gnu.org; Mon, 16 Aug 2010 21:55:47 -0400 Original-Received: from [140.186.70.92] (port=55140 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OlBOy-0004lP-MN for bug-gnu-emacs@gnu.org; Mon, 16 Aug 2010 21:55:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OlBOx-0002nt-5C for bug-gnu-emacs@gnu.org; Mon, 16 Aug 2010 21:55:44 -0400 Original-Received: from rgrjr.com ([216.146.47.5]:44741) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OlBOx-0002nT-2x for bug-gnu-emacs@gnu.org; Mon, 16 Aug 2010 21:55:43 -0400 Original-Received: from rgrjr.dyndns.org (c-66-30-196-77.hsd1.ma.comcast.net [66.30.196.77]) by rgrjr.com (Postfix on CentOS) with ESMTP id 1DDB61601B9 for ; Tue, 17 Aug 2010 01:55:41 +0000 (UTC) Original-Received: (qmail 28243 invoked by uid 89); 17 Aug 2010 01:55:40 -0000 Original-Received: from unknown (HELO rgr.rgrjr.com) (192.168.57.1) by home with SMTP; 17 Aug 2010 01:55:40 -0000 Original-Received: by rgr.rgrjr.com (Postfix, from userid 500) id D199B484F0; Mon, 16 Aug 2010 21:55:39 -0400 (EDT) X-Mailer: VM viewmail-600 under 24.0.50.1 (i686-pc-linux-gnu) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 16 Aug 2010 21:55:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:39555 Archived-At: It makes sense to me that vc-root-diff uses "(vc-responsible-backend default-directory)" when in a dired-mode buffer. But since vc-root-diff is not at all about the current buffer, why not also make that the default for shell-mode, diff-mode, or any of the other modes for non-version-controlled buffers that may be generated in a working copy? -- Bob Rogers http://www.rgrjr.com/ ------------------------------------------------------------------------ diff --git a/lisp/vc.el b/lisp/vc.el index 1e52a3c..abba202 100644 --- a/lisp/vc.el +++ b/lisp/vc.el @@ -1655,8 +1655,8 @@ saving the buffer." (when buffer-file-name (vc-buffer-sync not-urgent)) (let ((backend (cond ((derived-mode-p 'vc-dir-mode) vc-dir-backend) - ((derived-mode-p 'dired-mode) (vc-responsible-backend default-directory)) - (vc-mode (vc-backend buffer-file-name)))) + (vc-mode (vc-backend buffer-file-name)) + (t (vc-responsible-backend default-directory)))) rootdir working-revision) (unless backend (error "Buffer is not version controlled"))