From: rogers-emacs@rgrjr.dyndns.org
To: 6870@debbugs.gnu.org
Subject: bug#6870: Make vc-root-diff work in more modes
Date: Mon, 16 Aug 2010 21:55:39 -0400 [thread overview]
Message-ID: <19561.60443.364109.899857@rgr.rgrjr.com> (raw)
It makes sense to me that vc-root-diff uses "(vc-responsible-backend
default-directory)" when in a dired-mode buffer. But since vc-root-diff
is not at all about the current buffer, why not also make that the
default for shell-mode, diff-mode, or any of the other modes for
non-version-controlled buffers that may be generated in a working copy?
-- Bob Rogers
http://www.rgrjr.com/
------------------------------------------------------------------------
diff --git a/lisp/vc.el b/lisp/vc.el
index 1e52a3c..abba202 100644
--- a/lisp/vc.el
+++ b/lisp/vc.el
@@ -1655,8 +1655,8 @@ saving the buffer."
(when buffer-file-name (vc-buffer-sync not-urgent))
(let ((backend
(cond ((derived-mode-p 'vc-dir-mode) vc-dir-backend)
- ((derived-mode-p 'dired-mode) (vc-responsible-backend default-directory))
- (vc-mode (vc-backend buffer-file-name))))
+ (vc-mode (vc-backend buffer-file-name))
+ (t (vc-responsible-backend default-directory))))
rootdir working-revision)
(unless backend
(error "Buffer is not version controlled"))
next reply other threads:[~2010-08-17 1:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 1:55 rogers-emacs [this message]
2011-07-04 15:18 ` bug#6870: Make vc-root-diff work in more modes Lars Magne Ingebrigtsen
2011-07-04 18:13 ` Stefan Monnier
2011-07-05 13:32 ` Lars Magne Ingebrigtsen
2011-07-05 19:04 ` Stefan Monnier
2011-07-05 20:58 ` Chong Yidong
2020-08-25 13:38 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19561.60443.364109.899857@rgr.rgrjr.com \
--to=rogers-emacs@rgrjr.dyndns.org \
--cc=6870@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.