all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Roland Winkler" <Roland.Winkler@physik.uni-erlangen.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: BibTeX completion via completion-in-region
Date: Fri, 4 Dec 2009 22:56:44 -0600	[thread overview]
Message-ID: <19225.59404.211849.447292@regnitz.physics.niu.edu> (raw)

Hi Stefan

I noticed that you updated the completion code of BibTeX mode.
Three things:

- Suppose I want to complete the BibTeX string "AB".
  So I hit TAB while point is past the "AB".
  This gives me a buffer displaying possible completions, for example,
  "ABC" and "ABD".
  Then I select "ABC".
  This will insert the complete string "ABC" so that I get the
  awkward result "ABABC".
  I do not know whether this is related to the fact that
  completion-ignore-case is t in that case.
  (Maybe this is a known problem. There are some comments of that
  kind in minibuffer.el.)

- You greatly shortened the code of bibtex-complete-internal by
  calling completion-in-region. The code calling
  bibtex-complete-internal assumes that this function returns the
  completion. This still seems to work, though completion-in-region
  has no documented return value. So I suggest to make the
  completion the documented return value of completion-in-region.

- The return value of bibtex-complete-internal is used by
  bibtex-complete-string-cleanup which displays the expansion of the
  BibTeX string. Yet now this message can be hidden by the `Sole
  completion' message issued by minibuffer-complete. Here I am
  actually not sure what would be the best solution. I like the
  message that tells me the expansion of the BibTeX string (I cannot
  and will never be able to remember their meanings...). But I also
  understand that a "Sole completion' message can be helpful. And I
  know for sure that I am annoyed when one of these message is
  delayed by the other.

If you prefer, I can submit proper bug reports for these things.

Roland




             reply	other threads:[~2009-12-05  4:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-05  4:56 Roland Winkler [this message]
2009-12-05 16:08 ` BibTeX completion via completion-in-region Stefan Monnier
2009-12-05 17:45   ` Roland Winkler
2009-12-05 18:44     ` Stefan Monnier
2009-12-05 19:23       ` Roland Winkler
2009-12-05 23:49   ` bug#5130: 23.1.50; " Roland Winkler
2020-08-26 15:18     ` Stefan Kangas
2020-08-26 15:39       ` Stefan Kangas
2009-12-06  0:14   ` Roland Winkler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19225.59404.211849.447292@regnitz.physics.niu.edu \
    --to=roland.winkler@physik.uni-erlangen.de \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.