From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Bj=C3=B6rn?= Bidar via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#75305: 31.0.50; gnus-refer-thread-use-search isn't exact enough about how the current group is searched Date: Sun, 05 Jan 2025 22:33:59 +0200 Message-ID: <19076.2791711435$1736109323@news.gmane.org> References: <8634i0ia6l.fsf@gnu.org> <86o70md819.fsf@gnu.org> <86wmf9ai4k.fsf@gnu.org> Reply-To: =?UTF-8?Q?Bj=C3=B6rn?= Bidar Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26975"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eric Abrahamsen , 75305@debbugs.gnu.org, Andrew G Cohen To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 05 21:35:15 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tUXL8-0006qf-GS for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Jan 2025 21:35:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tUXKy-0004BG-LP; Sun, 05 Jan 2025 15:35:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tUXKw-0004A8-Sl for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2025 15:35:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tUXKw-0005AD-HL for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2025 15:35:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=aImAH9PmDFaXPbpcvLCcqTAAyTi+nXj+SgrOzHnHg/I=; b=JXqLbvmQeYamTUrORtdu58t5NKVpRxk9adoKtNEAtvBo+ESlfD9dG5jrGSx9aDLtXnvllYH/wjQ4gHk8LRqxAbO7E/Ec5iKnJhmCpuc3WCaYBLGnSWwBmae5k2rWEUBAkv42RT5TVVSfk5kLUYYRq6F68Avy7S8OzWQQF6XIdYZb8DMF4VQiAjB02YGit3Fl23FExJkmsP9kz0/M2RTMoIFCKQ2wc8agIRICCJ4vi+WLVFjYfETnOc/0tSwsHmMlCPdvb6SNmcRTVkfOts2np29meRWUJulVUMLBjfZUgQYrGLZHldrX9Tb9QtyLBtnmrm5JDewww2igsajfHYD+Gg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tUXKw-0008RA-Cs for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2025 15:35:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Bj=C3=B6rn?= Bidar Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Jan 2025 20:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75305 X-GNU-PR-Package: emacs Original-Received: via spool by 75305-submit@debbugs.gnu.org id=B75305.173610925432333 (code B ref 75305); Sun, 05 Jan 2025 20:35:02 +0000 Original-Received: (at 75305) by debbugs.gnu.org; 5 Jan 2025 20:34:14 +0000 Original-Received: from localhost ([127.0.0.1]:35419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUXKA-0008PR-9T for submit@debbugs.gnu.org; Sun, 05 Jan 2025 15:34:14 -0500 Original-Received: from thaodan.de ([2a03:4000:4f:f15::1]:56002) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tUXK4-0008Oj-FU for 75305@debbugs.gnu.org; Sun, 05 Jan 2025 15:34:12 -0500 Original-Received: from odin (dsl-trebng12-50dc7b-49.dhcp.inet.fi [80.220.123.49]) by thaodan.de (Postfix) with ESMTPSA id BA027D00098; Sun, 5 Jan 2025 22:34:00 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1736109240; bh=WlbFYGal2t104WP0MH4IlvOUeIBnYEN+pAmrJyAcJsU=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=VAc2tWEqcVOyGq9loHWmhN5q95mC+h8h3m0lfm1ykaE9e/cUFd3hePyqXatqW4WeN Og7+DbV9ecJIlR/U9H0L9qNBF4oqFi49DndMg+6cUQjblpmYozzR95UAMwZFQFSo94 /xJDZpOME0KSOuMjb0172Y7KfpRLe9mjsArQujdRZgyLXOpmPQk1+1H9UHz1r2wRs9 B2HdNTbcidVHvWs2fLwlBHOkYDXsFEA7XwWkB+zuQJ2RbKa2unjLx0HDgxhVb4B2oF XnivLLUmqDUBNwYymOpSQjsLsZnTNlTR2/HZiMYDrQv6ztFdUQrDIVvROkmIdUAD3P pB1iXO5Q0meyLfTqThsLNtb9lL/nZFExve0vYmPsXNevKRuo8Z4f9gsQsHGZf8Ey3e /ttpZrF+5XXGH7MvOlI7u3ugoDUL4doGR2kcSTVSLmnm3Jg4DkPRBW1O4XrmumEetS fDm7DVcFoShzjiFPjoBjD5hgS67t12GVWo20y9wbZPLCYvWQYUxT770ZP8uppkYSQu YWjQZBwwZuGZ6Sq/fpI57bDeJNMWe0dL4tPF8K6YpPmmbdnhtMnFItZIlamwfeB6kY AYIN1lHPPpA8kWhHqy21VUVsCi6xdHmFAGE0KAA0kkzcIUna6IQwUnGZtD6AxOCSjf /velnSJP8pOppoKlTkLheHGA= In-Reply-To: <86wmf9ai4k.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 05 Jan 2025 08:29:15 +0200") Autocrypt: addr=bjorn.bidar@thaodan.de; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlH X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298607 Archived-At: Eli Zaretskii writes: >> From: Bj=C3=B6rn Bidar >> Cc: 75305@debbugs.gnu.org >> Date: Sat, 04 Jan 2025 23:34:10 +0200 >>=20 >> Eli Zaretskii writes: >>=20 >> > Thanks, but the patch seems to include unrelated changes in the code? >> > I thought we were talking only about fixing the manual? Or what did I >> > miss? >> > >>=20 >> I look at the situation further and noticed that adding the current >> group does not work without the user writing a custom hook to add it. >> I already wrote a hook to change gnus-refer-thread-use-search for >> another reason, to add the current gnus-message-archive-group to=20 >> gnus-refer-thread-use-search. >> To just add the current group writing a hook would be to clumsy. >> Using the current symbol similar as in gnus-refer-article-method is much >> simpler, makes the setting easier to understand and customize for new=20 >> users. >>=20 >> The customization changes are there to use better custom types which >> makes it easier to customize and harder to put false values into the >> option when using custom. > > Then we'll need to wait for our Gnus expert (CC'ed) to review your > code changes. I have some comments to the documentation part below: OK great.=20 >> * lisp/gnus/gnus-sum.el (gnus-refer-thread-use-search): >> Make it easier to customize the variable by adding predefine choices >> as well as descriptions to each choice. Add option to add the value >> `current' to the list of servers and groups to add the current group. >> E.g. to add another group and the current group. >> * lisp/gnus/gnus-search.el (gnus-refer-thread-maybe-add-current-group, >> gnus-search-thread): Add helper function to determine if the option >> contains the value current. Use helper function. >> * lisp/gnus/nnselect.el (nnselect-request-thread): Use helper function >> to check if the value current is in gnus-refer-thread-use-search. >> * doc/misc/gnus.texi (gnus-refer-thread-use-search): >> Include the current value in the section. Format the section a little >> better to have a paragraph for each possible value that the option >> may contain. Explain the option to have a list of servers more detailed >> , i.e. similarly to the custom description. Highlight that the current >> group is not searched unless specified. Explain that unless the articles >> of that thread are contained in the searched groups not adding the >> current group might not be the desired effect. > > Some of the lines in the log message are too long. Please be sure to > wrap lines at column 64 if possible, and in any case before column 70. > I did so but it does make the message harder to read when long function or variable names come into play. The grammar errors you noticed are fixed. I also applied the suggested changes to the docstring of the new function.