From: Eli Barzilay <eli@barzilay.org>
To: Juri Linkov <juri@jurta.org>
Cc: 4117@emacsbugs.donarmstrong.com
Subject: bug#4117: 23.1; isearch + isearch-allow-scroll loses shift
Date: Wed, 12 Aug 2009 19:59:11 -0400 [thread overview]
Message-ID: <19075.22351.611859.436166@winooski.ccs.neu.edu> (raw)
In-Reply-To: <87bpmkhcdb.fsf@mail.jurta.org>
On Aug 12, Juri Linkov wrote:
> > When `isearch-allow-scroll' is turned on, then exiting isearch with
> > a movement command loses its "shift" status. To see this, use
> > isearch and look for some string, then hit C-S-right a few times and
> > you will see that the first one does not starts a selection.
>
> When `isearch-allow-scroll' is non-nil, then
> `isearch-other-meta-char' calls
> `isearch-reread-key-sequence-naturally', but `read-key-sequence' in
> the latter function removes the shift modifier and sets
> `this-command-keys-shift-translated' to t.
Yes, I hacked around it with my own version of
`isearch-other-meta-char'. (But I don't think that it's a good
hack...)
> This is just an analysis. I currently don't know what is the right
> way to fix this. Maybe simply add the shift modifier back to the
> key when `this-command-keys-shift-translated' to t after
> `read-key-sequence'.
This sounds like a good strategy, given that shift is now very useful
in general.
--
((lambda (x) (x x)) (lambda (x) (x x))) Eli Barzilay:
http://barzilay.org/ Maze is Life!
next prev parent reply other threads:[~2009-08-12 23:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-11 10:48 bug#4117: 23.1; isearch + isearch-allow-scroll loses shift Eli Barzilay
2009-08-12 20:54 ` Juri Linkov
2009-08-12 23:59 ` Eli Barzilay [this message]
2009-08-15 23:27 ` Juri Linkov
2009-08-16 0:00 ` Eli Barzilay
2009-08-17 0:47 ` Juri Linkov
2009-08-17 3:17 ` Eli Barzilay
2009-08-17 15:07 ` Stefan Monnier
2009-08-17 19:53 ` Eli Barzilay
2009-08-17 21:19 ` Juri Linkov
2009-08-17 21:18 ` Juri Linkov
2009-08-18 2:56 ` Stefan Monnier
2009-08-19 0:56 ` Juri Linkov
2009-08-19 3:27 ` Stefan Monnier
2016-06-18 3:53 ` Andrew Hyatt
[not found] ` <mailman.1719.1466222049.1216.bug-gnu-emacs@gnu.org>
2016-06-19 13:18 ` Alan Mackenzie
[not found] <<19073.19554.183166.905858@winooski.ccs.neu.edu>
[not found] ` <<20160619131846.68080.qmail@mail.muc.de>
2016-06-19 14:36 ` Drew Adams
2016-06-20 0:57 ` Andrew Hyatt
2016-06-20 3:50 ` Eli Barzilay
2016-06-23 3:23 ` Andrew Hyatt
2016-06-23 4:18 ` Eli Barzilay
2016-06-23 18:15 ` Andrew Hyatt
2016-07-07 17:23 ` Eli Barzilay
2016-07-09 12:38 ` Andrew Hyatt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19075.22351.611859.436166@winooski.ccs.neu.edu \
--to=eli@barzilay.org \
--cc=4117@emacsbugs.donarmstrong.com \
--cc=juri@jurta.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.