From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: master bb9133f09da: * lisp/emacs-lisp/ert.el (ert-run-tests-batch-and-exit): Inhibit interaction Date: Mon, 14 Aug 2023 16:25:13 +0200 Message-ID: <18DBF0B1-8534-48C2-B5FE-4B324A93AB2A@gmail.com> References: <169195451549.1474.16374421496442723026@vcs2.savannah.gnu.org> <20230813192155.C53CEC295F9@vcs2.savannah.gnu.org> <87ttt22j2a.fsf@gmx.de> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23098"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Michael Albinus , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 14 19:46:28 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qVbe8-0005sd-Ej for ged-emacs-devel@m.gmane-mx.org; Mon, 14 Aug 2023 19:46:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qVbdS-0002CK-F7; Mon, 14 Aug 2023 13:45:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVYVU-0006h7-F8 for emacs-devel@gnu.org; Mon, 14 Aug 2023 10:25:20 -0400 Original-Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qVYVR-0005Oq-NI for emacs-devel@gnu.org; Mon, 14 Aug 2023 10:25:20 -0400 Original-Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2bb734a9081so14076651fa.1 for ; Mon, 14 Aug 2023 07:25:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692023116; x=1692627916; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=Q6BytPQisw9bUsr2Q9wvF4nZJj8djuu/IUd54krE2fk=; b=aT4yBDGHRuBZ2epcTuOEQgBhpsl7wLl79vhBivn4JaSbZmZF7ssc54MnPZsotP1zac WB4H8WoU1CKNlUZsODOvqVxG0pGiptSKcy/V4wxjk9NIn7ZNNc46F3MF+gCTML8Wxe/2 vyX8nlyCzwkB4wXOBaiRQgmwRMEKDxAzLLw6OPYn5gfP09Nid7kHmzzmJdOICwd7wbFD 8Y27gilydl7UjZWJNmLEwk0EjMP8IcjhH4UfjfqRtAbeU0lwR2SdYwYtImnZaK/ybfZ0 Lqh3IkyKiYlqRU8cdgT0CLV/rgs4VFcliFOT5SZ8xbt6r4GSBTkP4KGwBGkkv2T8oxjX QA4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692023116; x=1692627916; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Q6BytPQisw9bUsr2Q9wvF4nZJj8djuu/IUd54krE2fk=; b=BjNQpwdwI49364F/YWuugdG9O+nFls9o3WfCdR0bW9MtUn3DyOggv2zcEZgmwipKEK s5++pc0yT3EL+shkrD3ScBwCzJ47T+kY1hyw0Ke3zGMkkif+8kcZd3QniebxSgvt+wOW kyo8Nzul0sewSDWo3XSYEdywWZp5eqIDJcOv7OapYaqs/XMBgkwZOPjWfIY0u/HxOprW acAFzgk4fESur5na4goMTC2baCBzqdyg7RJCRPUBg6alDd8tj++A0fevMa6SB/0pxREV 3Gqs8zzA8rMsHEmkqn+8Ht/m8cMZy2DiLyVpaSSalpgtP1w9FhMa8mBs+mj+Y7Rs7aIJ +1Lw== X-Gm-Message-State: AOJu0YwxRUEOfOO0Okzcg1oTw2itQHPXAc7yH0crTmAGmPU7cdD8nKtD sjnzKywx7TJsdcwioia2Nio= X-Google-Smtp-Source: AGHT+IEEKTP1KZOlCaeIIFTp/0/QT1UkwMgF7fLeqanKZfdx8fWf6y5OirZ/T2ycnIys0CXXKP4Egw== X-Received: by 2002:a2e:a4d9:0:b0:2b9:b8ce:4219 with SMTP id p25-20020a2ea4d9000000b002b9b8ce4219mr4753747ljm.6.1692023115417; Mon, 14 Aug 2023 07:25:15 -0700 (PDT) Original-Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id k5-20020a2e9205000000b002b6c56fe862sm2361393ljg.63.2023.08.14.07.25.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Aug 2023 07:25:14 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3654.120.0.1.15) Received-SPF: pass client-ip=2a00:1450:4864:20::233; envelope-from=mattias.engdegard@gmail.com; helo=mail-lj1-x233.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 14 Aug 2023 13:45:45 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308741 Archived-At: 14 aug. 2023 kl. 16.00 skrev Stefan Monnier : > FWIW, I added it because I'm seeing tests (e.g. `file-tests.el`) hang = in > `read-event` (apparently because a (cl-letf ((symbol-function ..)) ..) > rebinding is not taking effect :-( ) and I figured that batch tests > should indeed never need interaction. I agree, but some tests persist. For example, abbrev-tests uses = ert-simulate-keys to 'interact' with Emacs. Other test do morally equivalent things, and it is indubitably useful to = be able to test interactive features non-interactively in some way.