From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#7296: display-pixel-height not enough Date: Tue, 2 Nov 2010 11:24:15 -0700 Message-ID: <1886CEE3C5E349D2A645454175C010DE@us.oracle.com> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1288723421 8490 80.91.229.12 (2 Nov 2010 18:43:41 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 2 Nov 2010 18:43:41 +0000 (UTC) Cc: 7296@debbugs.gnu.org To: Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 02 19:43:36 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PDLpV-00063l-UN for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Nov 2010 19:43:34 +0100 Original-Received: from localhost ([127.0.0.1]:33744 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PDLpU-0004VI-V1 for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Nov 2010 14:43:33 -0400 Original-Received: from [140.186.70.92] (port=34320 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PDLpM-0004Uu-MB for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2010 14:43:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PDLpL-00038k-Bh for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2010 14:43:24 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47398) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PDLpL-00038a-7X for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2010 14:43:23 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PDLTh-0001IS-Lc; Tue, 02 Nov 2010 14:21:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Nov 2010 18:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7296 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7296-submit@debbugs.gnu.org id=B7296.12887220064976 (code B ref 7296); Tue, 02 Nov 2010 18:21:01 +0000 Original-Received: (at 7296) by debbugs.gnu.org; 2 Nov 2010 18:20:06 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PDLSn-0001ID-Lw for submit@debbugs.gnu.org; Tue, 02 Nov 2010 14:20:05 -0400 Original-Received: from rcsinet10.oracle.com ([148.87.113.121]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PDLSm-0001Ho-Gj for 7296@debbugs.gnu.org; Tue, 02 Nov 2010 14:20:05 -0400 Original-Received: from rcsinet13.oracle.com (rcsinet13.oracle.com [148.87.113.125]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id oA2IOPB1011728 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 2 Nov 2010 18:24:27 GMT Original-Received: from acsmt353.oracle.com (acsmt353.oracle.com [141.146.40.153]) by rcsinet13.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id oA2H1sI5016664; Tue, 2 Nov 2010 18:24:24 GMT Original-Received: from abhmt019.oracle.com by acsmt355.oracle.com with ESMTP id 741879511288722257; Tue, 02 Nov 2010 11:24:17 -0700 Original-Received: from dradamslap1 (/10.159.219.93) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 02 Nov 2010 11:24:17 -0700 X-Mailer: Microsoft Office Outlook 11 Thread-Index: Act57+U4Wz+HVoFXQme/EoUozw5IwgAAM+aQADKHlTA= X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 02 Nov 2010 14:21:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:41376 Archived-At: For some reason, it seems this message never made it to the BUGS list. = Sending again.=20 -----Original Message----- From: Drew Adams Sent: Monday, November 01, 2010 11:36 AM To: 'Lennart Borgman' Cc: 'YAMAMOTO Mitsuharu'; '7296@debbugs.gnu.org' > > It's not that one or the other is better; it's that they=20 > > are different. =A0If you change the meaning and return value > > of an existing function then you break existing code. =A0If > > you want to add an additional function that returns some > > other value that you find more useful, that's one thing. =A0 > > Proposing to change the existing function is something else again. >=20 > There is no clear description of what display-pixel-height currently > returns. So how do we know how it is currently used? I know how I currently use it (and I pointed you to the code). And my = code has been been used by others as well (it is included in Aquamacs, AFAIK). = It seems to DTRT. How did I find out what `display-pixel-height' returns? Well, I tried = it out, for one thing. And I read the doc string, which I found clear enough. You cannot change the behavior of something radically just because you = feel the doc is not precise enough. Imprecise doc is not a license to change up = to down or whole to part. These functions have been around quite a while. If you want something incompatibly different then create a new function. Do not try to turn = the existing functions upside down. > It looks like it is difficult to get this information, but as I said > the current return value must be documented. I suggest that we just > change the doc string and says that it returns value for the total > display. I'm all for clear doc. But in this case I don't see the difference. If = I tell you that function `foobar' returns the diameter of its input circle, is = that different from telling you that it returns the "total" diameter? Is the length of your bicycle different from the length of your whole = bicycle? With no qualifier I think that the entire display is understood = implicitly. > And in addition to that it would probably be good to have the > "opposite" function too. At least I need it. It is in the doc of your new, partial-height function that you would = state that it returns the height of only part of the (total) display. In sum, you are looking for a different behavior from what `display-pixel-height' provides. For that you should be asking for a = different function - exactly as you would do if you wanted to change the return = units from pixels to lines. This is not a doc issue IMO, and IMO it is not a problem with `display-pixel-height'. What you are asking for is (or should be) a = new, additional function.