From: Nick Roberts <nickrob@snap.net.nz>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 2092-done@emacsbugs.donarmstrong.com, emacs-pretest-bug@gnu.org
Subject: bug#2092: 23.0.60; vc-svn-diff
Date: Thu, 5 Feb 2009 00:03:01 +1300 [thread overview]
Message-ID: <18825.30181.243954.921791@kahikatea.snap.net.nz> (raw)
In-Reply-To: <jwvd4e17plj.fsf-monnier+emacsbugreports@gnu.org>
> > vc-svn-diff fails when oldvers equals (vc-working-revision f).
> > In that case "svn diff" executes with no -r argument and only gives
> > a diff if the file is locally modified.
>
> That's the right behavior when newvers is nil, isn't it?
>
> > I don't see how it could ever work (please note that I'm not saying that
> > it could never work just that I don't see how it could).
>
> I think it was written assuming (incorrectly) that "newvers == nil".
> Is the bug fixed if you add (null newvers) to the conjunction?
>
>
> Stefan
>
>
> PS: I see you've already removed this code, but I remember we added
> specifically upon request from some users, so it would be better to fix
> it than to remove it.
OK, I've looked through the archives. I find it odd because:
1) I think that svn should be able to work out whether it can handle a
request locally (a bug in svn?).
2) If you do "C-x v =" there is no problem.
3) I can only see a problem with "C-u C-x v =" with the default values which
is eqivalent to 2).
So it looks very much like a corner case.
Anyway I've done as you say.
--
Nick http://www.inet.net.nz/~nickrob
next prev parent reply other threads:[~2009-02-04 11:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-28 6:34 bug#2092: 23.0.60; vc-svn-diff Nick Roberts
2009-02-01 22:39 ` Stefan Monnier
2009-02-04 11:03 ` Nick Roberts [this message]
2009-02-04 19:42 ` Stefan Monnier
2009-02-04 11:10 ` bug#2092: marked as done (23.0.60; vc-svn-diff) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18825.30181.243954.921791@kahikatea.snap.net.nz \
--to=nickrob@snap.net.nz \
--cc=2092-done@emacsbugs.donarmstrong.com \
--cc=2092@emacsbugs.donarmstrong.com \
--cc=emacs-pretest-bug@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.