From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nick Roberts Newsgroups: gmane.emacs.devel Subject: Re: VC Development Date: Sun, 1 Feb 2009 21:16:58 +1300 Message-ID: <18821.23162.152202.54979@kahikatea.snap.net.nz> References: <18820.57748.262639.494922@kahikatea.snap.net.nz> <8763ju6gh9.fsf@cyd.mit.edu> <200902010602.n11620Ek019863@rodan.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1233476257 24007 80.91.229.12 (1 Feb 2009 08:17:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 1 Feb 2009 08:17:37 +0000 (UTC) Cc: Chong Yidong , emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 01 09:18:49 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LTXXT-0004JM-V5 for ged-emacs-devel@m.gmane.org; Sun, 01 Feb 2009 09:18:48 +0100 Original-Received: from localhost ([127.0.0.1]:36241 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LTXW8-0001VX-Sm for ged-emacs-devel@m.gmane.org; Sun, 01 Feb 2009 03:17:24 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LTXW4-0001VS-8e for emacs-devel@gnu.org; Sun, 01 Feb 2009 03:17:20 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LTXW1-0001VG-UA for emacs-devel@gnu.org; Sun, 01 Feb 2009 03:17:19 -0500 Original-Received: from [199.232.76.173] (port=59713 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LTXW1-0001VD-Pr for emacs-devel@gnu.org; Sun, 01 Feb 2009 03:17:17 -0500 Original-Received: from viper.snap.net.nz ([202.37.101.23]:47325) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LTXVz-0006Lk-QU for emacs-devel@gnu.org; Sun, 01 Feb 2009 03:17:16 -0500 Original-Received: from kahikatea.snap.net.nz (unknown [123.255.31.177]) by viper.snap.net.nz (Postfix) with ESMTP id 799803DBAB5; Sun, 1 Feb 2009 21:17:11 +1300 (NZDT) Original-Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 29A0B8FC6D; Sun, 1 Feb 2009 21:16:59 +1300 (NZDT) In-Reply-To: <200902010602.n11620Ek019863@rodan.ics.uci.edu> X-Mailer: VM 7.19 under Emacs 22.3.1 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:108508 Archived-At: > Seeing obviously wrong stuff like this: > +;; Keep existing map. > +(defvar vc-dir-mouse-map > + (let ((map vc-dir-mode-map)) > + (define-key map [mouse-2] 'vc-dir-find-file-other-window) > + map) > + "Local keymap for visiting a file.") > I don't have time to fix it properly now, so the best thing to do is to > revert it. I don't have time to waist on an email discussion for such > a trivial issue. OK. I see now that I should have used copy-keymap: (defvar vc-dir-mouse-map (let ((map (copy-keymap vc-dir-mode-map))) ... I would like to see this change go in before the pretest. Since I'm evidently in Dan's killfile this must be a request to the maintainers. In case there is any confusion, with my proposed change, mouse-2 still toggles the mark when clicked over the status (first mouse highlight region) but over the filename (second mouse highlight region) now visits that file in another buffer. I would also like to see stay-local behaviour working. I can look at making vc-svn-registered not use "svn status -v DIR", so that vc-stay-local-p is not so slow, but clearly it is not worthwhile if Dan is going to revert all my changes and refuse to discuss the reasons why. -- Nick http://www.inet.net.nz/~nickrob