From: Saulius Menkevicius <sauliusmenkevicius@fastmail.com>
To: Robert Pluim <rpluim@gmail.com>
Cc: Alan Third <alan@idiocy.org>,
emacs-devel@gnu.org, p.stephani2@gmail.com,
Matt Armstrong <matt@rfc20.org>, Eli Zaretskii <eliz@gnu.org>,
mituharu@math.s.chiba-u.ac.jp
Subject: Re: master 2c79a8f 2/2: Use posix_spawn if possible.
Date: Mon, 7 Feb 2022 23:12:27 +0200 [thread overview]
Message-ID: <187BA387-6D96-457A-A157-388AD9379D85@fastmail.com> (raw)
In-Reply-To: <7BD6026F-D756-42C3-9FCC-724D9A6B2378@fastmail.com>
Hello Robert, Eli,
I can confirm that this patch is needed for emacs-28 too, as currently emacs on macOS blocks SIGCHLD the same way as it does on Linux.
Applying Robert’s patch on emacs-28 fixes the issue on macOS.
Tested on macOS 12.2 / aarch64.
-Saulius
> Am 2022-02-02 um 10:54 schrieb Saulius Menkevičius <sauliusmenkevicius@fastmail.com>:
>
> I’ve just received a new Mac (arm64/M1) for myself so I can test if 28 has it broken on macOS too.
>
> —Saulius Menkevičius
>
>> Am 2022-02-02 um 10:30 schrieb Robert Pluim <rpluim@gmail.com>:
>>
>>
>>>
>>>>>>> On Tue, 01 Feb 2022 21:52:18 +0200, Eli Zaretskii <eliz@gnu.org> said:
>>
>>>> From: Robert Pluim <rpluim@gmail.com>
>>>> Cc: Eli Zaretskii <eliz@gnu.org>, Matt Armstrong <matt@rfc20.org>,
>>>> p.stephani2@gmail.com, alan@idiocy.org, mituharu@math.s.chiba-u.ac.jp,
>>>> emacs-devel@gnu.org
>>>> Date: Tue, 01 Feb 2022 20:23:23 +0100
>>>>
>>>>>>>>> On Tue, 1 Feb 2022 20:30:18 +0200, Saulius Menkevicius <sauliusmenkevicius@fastmail.com> said:
>>>>
>> Saulius> Thanks Robert!
>> Saulius> I applied your patch and that has actually has fixed the issue. So I
>> Saulius> suggest this patch be applied on master.
>>>>
>>>> I can do that, if Eli/Lars agree.
>>
>> Eli> Are there any downsides to the patch? If not, I see no reasons not to
>> Eli> install that.
>>
>> Not as far as I can tell, but I shall test on a few more platforms
>> before pushing.
>>
>>>> What should we do for emacs-28?
>>
>> Eli> Nothing, because on emacs-28 we use posix_spawn only on macOS.
>>
>> Right, Iʼd missed that, master it is then. We could put it in 28.2, I
>> guess, but I hadn't noticed any issues with subprocesses on emacs-28
>> on macOS.
>>
>> Robert
>> --
next prev parent reply other threads:[~2022-02-07 21:12 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 6:48 master 2c79a8f 2/2: Use posix_spawn if possible Saulius Menkevicius
2022-01-25 8:41 ` Eli Zaretskii
2022-01-25 8:58 ` Saulius Menkevicius
2022-01-25 11:46 ` Jostein Kjønigsen
2022-01-25 11:55 ` Po Lu
2022-01-25 12:22 ` Eli Zaretskii
2022-01-25 12:25 ` Saulius Menkevicius
2022-01-25 13:47 ` Eli Zaretskii
2022-01-28 17:12 ` Matt Armstrong
2022-01-29 8:03 ` Saulius Menkevičius
2022-01-29 8:26 ` Eli Zaretskii
2022-01-31 20:48 ` Saulius Menkevicius
2022-02-01 9:59 ` Robert Pluim
2022-02-01 18:30 ` Saulius Menkevicius
2022-02-01 19:23 ` Robert Pluim
2022-02-01 19:52 ` Eli Zaretskii
2022-02-02 8:30 ` Robert Pluim
2022-02-02 8:54 ` Saulius Menkevičius
2022-02-07 21:12 ` Saulius Menkevicius [this message]
2022-02-08 8:27 ` Robert Pluim
2022-02-08 12:12 ` Eli Zaretskii
2022-02-08 12:18 ` Saulius Menkevicius
2022-02-08 14:59 ` Robert Pluim
2022-02-08 21:09 ` Saulius Menkevicius
2022-02-09 8:48 ` Robert Pluim
2022-02-12 8:44 ` Saulius Menkevicius
2022-02-12 8:59 ` Eli Zaretskii
2022-02-12 9:42 ` Saulius Menkevicius
2022-03-04 8:38 ` [PATCH] posix_spawn blocks SIGCHLD in spawned processes (was: Re: master 2c79a8f 2/2: Use posix_spawn if possible.) Jürgen Hötzel
2022-03-04 10:07 ` [PATCH] posix_spawn blocks SIGCHLD in spawned processes Robert Pluim
2022-03-04 15:41 ` Jürgen Hötzel
2022-03-04 16:08 ` Robert Pluim
2022-04-17 18:22 ` Philipp Stephani
2022-04-19 14:36 ` Robert Pluim
2022-04-19 14:48 ` Philipp Stephani
2022-04-19 16:07 ` Eli Zaretskii
2022-04-19 17:32 ` Robert Pluim
2022-04-04 14:13 ` Robert Pluim
2022-01-25 13:15 ` master 2c79a8f 2/2: Use posix_spawn if possible Stefan Monnier
-- strict thread matches above, loose matches on Subject: below --
2021-11-08 11:00 Aaron Jensen
2021-11-08 11:03 ` Aaron Jensen
2021-11-08 19:37 ` Alan Third
2021-11-09 14:46 ` Philipp
2021-11-09 15:57 ` Aaron Jensen
2021-11-09 17:05 ` Eli Zaretskii
2021-11-09 18:12 ` Aaron Jensen
2021-11-12 11:48 ` Philipp
2021-11-12 13:42 ` Aaron Jensen
2021-11-12 22:05 ` Alan Third
2021-11-13 14:08 ` Aaron Jensen
2021-11-13 16:03 ` Philipp
2021-11-13 16:17 ` Aaron Jensen
2021-11-15 15:01 ` Dmitry Gutov
2020-12-25 13:16 Eli Zaretskii
2020-12-26 11:26 ` Philipp Stephani
2020-12-26 12:08 ` Eli Zaretskii
2020-12-26 12:16 ` Eli Zaretskii
2020-12-29 16:43 ` Philipp Stephani
2020-12-31 16:24 ` Philipp Stephani
2020-12-31 16:39 ` Eli Zaretskii
2020-12-31 17:36 ` Philipp Stephani
2020-12-31 17:47 ` Eli Zaretskii
2020-12-31 20:24 ` Philipp Stephani
2020-12-31 20:36 ` Eli Zaretskii
2021-01-01 7:59 ` martin rudalics
2021-01-01 8:04 ` Eli Zaretskii
2021-01-01 23:38 ` Andy Moreton
2021-01-01 23:56 ` Alan Third
2021-01-02 1:12 ` Andy Moreton
2021-01-02 6:53 ` Eli Zaretskii
2021-01-02 8:56 ` Andreas Schwab
2021-10-29 9:46 ` YAMAMOTO Mitsuharu
2021-10-30 18:30 ` Alan Third
2021-11-02 19:58 ` Alan Third
2021-11-02 20:15 ` Eli Zaretskii
2021-11-02 20:36 ` Alan Third
2021-11-03 3:24 ` Eli Zaretskii
2021-11-10 12:42 ` Philipp Stephani
2021-11-10 14:10 ` Eli Zaretskii
2021-11-11 17:52 ` Philipp
2021-11-11 18:00 ` Eli Zaretskii
2021-11-11 21:04 ` Philipp
2020-12-29 16:29 ` Philipp Stephani
2020-12-29 18:15 ` Eli Zaretskii
2020-12-29 21:36 ` Philipp Stephani
2020-12-30 3:33 ` Eli Zaretskii
2020-12-31 16:10 ` Philipp Stephani
2020-12-31 18:33 ` Eli Zaretskii
2020-12-31 17:50 ` Philipp Stephani
2020-12-31 18:34 ` Eli Zaretskii
2020-12-31 20:14 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=187BA387-6D96-457A-A157-388AD9379D85@fastmail.com \
--to=sauliusmenkevicius@fastmail.com \
--cc=alan@idiocy.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=matt@rfc20.org \
--cc=mituharu@math.s.chiba-u.ac.jp \
--cc=p.stephani2@gmail.com \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.