From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ulrich Mueller Newsgroups: gmane.emacs.bugs,gmane.emacs.pretest.bugs Subject: bug#1797: 23.0.60; completing-read breaks backwards compatibility Date: Tue, 6 Jan 2009 10:34:52 +0100 Message-ID: <18787.9660.526503.139106@a1ihome1.kph.uni-mainz.de> References: <18786.40315.242106.507079@a1ihome1.kph.uni-mainz.de> Reply-To: Ulrich Mueller , 1797@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1231236233 4340 80.91.229.12 (6 Jan 2009 10:03:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 6 Jan 2009 10:03:53 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, 1797@emacsbugs.donarmstrong.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 06 11:05:01 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LK8nu-0002m7-5D for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Jan 2009 11:04:54 +0100 Original-Received: from localhost ([127.0.0.1]:59947 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LK8me-0003Bg-B0 for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Jan 2009 05:03:36 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LK8mY-0003BH-46 for bug-gnu-emacs@gnu.org; Tue, 06 Jan 2009 05:03:30 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LK8mV-0003Ad-3q for bug-gnu-emacs@gnu.org; Tue, 06 Jan 2009 05:03:29 -0500 Original-Received: from [199.232.76.173] (port=41560 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LK8mU-0003Aa-QF for bug-gnu-emacs@gnu.org; Tue, 06 Jan 2009 05:03:26 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:38567) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LK8mU-00065i-6S for bug-gnu-emacs@gnu.org; Tue, 06 Jan 2009 05:03:26 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n06A3NGi032103; Tue, 6 Jan 2009 02:03:24 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n069j47f027414; Tue, 6 Jan 2009 01:45:04 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Ulrich Mueller Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 06 Jan 2009 09:45:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 1797 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1797-submit@emacsbugs.donarmstrong.com id=B1797.123123450825385 (code B ref 1797); Tue, 06 Jan 2009 09:45:04 +0000 Original-Received: (at 1797) by emacsbugs.donarmstrong.com; 6 Jan 2009 09:35:08 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from a1iwww1.kph.uni-mainz.de (a1iwww1.kph.uni-mainz.de [134.93.134.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n069YxA1024790 for <1797@emacsbugs.donarmstrong.com>; Tue, 6 Jan 2009 01:35:00 -0800 Original-Received: from a1ihome1.kph.uni-mainz.de (a1ihome1.kph.uni-mainz.de [134.93.134.75]) by a1iwww1.kph.uni-mainz.de (8.14.0/8.13.4) with ESMTP id n069Yqip005322; Tue, 6 Jan 2009 10:34:53 +0100 Original-Received: from a1ihome1.kph.uni-mainz.de (localhost [127.0.0.1]) by a1ihome1.kph.uni-mainz.de (8.14.0/8.14.1) with ESMTP id n069Yq2x011337; Tue, 6 Jan 2009 10:34:52 +0100 Original-Received: (from ulm@localhost) by a1ihome1.kph.uni-mainz.de (8.14.0/8.14.0/Submit) id n069Yq3A011332; Tue, 6 Jan 2009 10:34:52 +0100 In-Reply-To: X-Mailer: VM 8.0.2-487 under Emacs 22.2.1 (i686-pc-linux-gnu) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Tue, 06 Jan 2009 05:03:29 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:23816 gmane.emacs.pretest.bugs:23622 Archived-At: >>>>> On Mon, 05 Jan 2009, Stefan Monnier wrote: > Thanks. I installed a change which I believe should fix this bug. I confirm that today's CVS trunk is working as expected. > Note that your completion function is a prime example of a completion > table that needs completion-boundaries in order to work right. > ((eq (car-safe mode) 'boundaries) > (lexical-let* ((suffix (cdr mode)) > (start (or (match-end 1) 0)) > (end (string-match "\\s-" suffix))) > (lambda (s table pred) > `(boundaries ,start . ,end)))) Hey, I had already come to a very similar solution: ;-) (defun my-complete (s pred mode) (string-match "^\\(.*\\s-\\)?\\(.*\\)$" s) + (if (eq (car-safe mode) 'boundaries) ; GNU Emacs 23 + (cons 'boundaries + (cons (match-beginning 2) + (string-match "\\s-" (cdr mode)))) (let* ((s1 (match-string 1 s)) (s2 (match-string 2 s)) It cost me quite some time to get this right, because of the missing documentation. Ulrich