From: Mike Kupfer <mkupfer@alum.berkeley.edu>
To: emacs-devel@gnu.org
Subject: [PATCH] Fix MH-E mail composition with GNU Mailutils
Date: Sat, 30 Jun 2018 12:00:40 -0700 [thread overview]
Message-ID: <18700.1530385240@alto> (raw)
Currently, trying to compose a message using MH-E with Mailutils fails:
no composition buffer is created, and the user gets an obscure error
message about deleting a non-empty directory. This has been broken for
awhile (i.e., it's not a regression in 26.1), but the fix is pretty
simple. Is this okay for emacs-26?
diff --git a/lisp/mh-e/mh-comp.el b/lisp/mh-e/mh-comp.el
index a9f809cfa1..aa22df8b18 100644
--- a/lisp/mh-e/mh-comp.el
+++ b/lisp/mh-e/mh-comp.el
@@ -925,8 +925,10 @@ mh-bare-components
(list "-form" mh-comp-formfile)))
(setq new (make-temp-file "comp."))
(rename-file (concat temp-folder "/" "1") new t)
- (delete-file (concat temp-folder "/" ".mh_sequences"))
- (delete-directory temp-folder)
+ ;; The temp folder could contain various metadata files. Rather
+ ;; than trying to enumerate all the known files, just do a
+ ;; recursive delete on the directory.
+ (delete-directory temp-folder t)
new))
(defun mh-read-draft (use initial-contents delete-contents-file)
thanks,
mike
next reply other threads:[~2018-06-30 19:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-30 19:00 Mike Kupfer [this message]
2018-06-30 19:21 ` [PATCH] Fix MH-E mail composition with GNU Mailutils Eli Zaretskii
2018-06-30 20:55 ` Mike Kupfer
2018-07-04 16:38 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18700.1530385240@alto \
--to=mkupfer@alum.berkeley.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.