From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#47832: 28.0.50; define-fringe-bitmap and emacs --daemon Date: Sat, 17 Apr 2021 11:27:56 +0000 Message-ID: <1869622e16c4eb74d974@heytings.org> References: <7dee3f4235cf450a3254@heytings.org> <83mttxwgm8.fsf@gnu.org> <1869622e16688e6aedec@heytings.org> <83h7k5w54l.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37657"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47832@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 17 13:29:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lXj8P-0009hf-KH for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Apr 2021 13:29:09 +0200 Original-Received: from localhost ([::1]:37098 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lXj8O-0007ww-9U for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Apr 2021 07:29:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39302) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXj8I-0007wp-OO for bug-gnu-emacs@gnu.org; Sat, 17 Apr 2021 07:29:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59056) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lXj8I-0002hx-HJ for bug-gnu-emacs@gnu.org; Sat, 17 Apr 2021 07:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lXj8I-00030e-DN for bug-gnu-emacs@gnu.org; Sat, 17 Apr 2021 07:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Apr 2021 11:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47832 X-GNU-PR-Package: emacs Original-Received: via spool by 47832-submit@debbugs.gnu.org id=B47832.161865888311501 (code B ref 47832); Sat, 17 Apr 2021 11:29:02 +0000 Original-Received: (at 47832) by debbugs.gnu.org; 17 Apr 2021 11:28:03 +0000 Original-Received: from localhost ([127.0.0.1]:42369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXj7L-0002zR-K9 for submit@debbugs.gnu.org; Sat, 17 Apr 2021 07:28:03 -0400 Original-Received: from heytings.org ([95.142.160.155]:41546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXj7G-0002yz-5W for 47832@debbugs.gnu.org; Sat, 17 Apr 2021 07:28:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1618658877; bh=nWdITWnehK34JeZs65RYBHoAOxozsmihJkhAlKUZhjo=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=o6mzFY5duBQ1N6IaOTMFF3dufFpgOi2Fmhp/rzukkRYdETK9dXvLIGkbmcR6B/Ms2 enmrdrmzsfoy8vmtwzzNqvKhNYzkwjZBdSkOTkBWwBqhdqTtKwLCSdezGxU7X6I7Tz L8iV+X6jwi0jsRkFbuF/RraQs6gdkMqK/GrS7lxSqP4/AGX4Ur/L8eKAtvzQG2JsEC JpO1DirG4ftLImuYToUmevWBw6IOQ0AUmkUaHe4fZTXDT8ydfYiEBIW0iXwBA7atQI H5aAPoyeYHAxI0VFSNOpKZ+dAlXq3BmYXWl7s7Egjz/kbV9jRusUQLADoUBLCbv1cp C9DA+U8MZyM0A== In-Reply-To: <83h7k5w54l.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204186 Archived-At: >> This used to work indeed; it worked on GNU/Linux with default >> (non-Cairo) builds for Emacs 24 to 27. > > And with Emacs 28 it doesn't work in non-Cairo builds? > Yes, with Emacs 28 it works with non-Cairo builds. >> Got it! :-) The commit I identified is indeed the culprit. With >> USE_CAIRO, gui_init_fringe() is called in x_initialize(); without >> USE_CAIRO it isn't. And gui_init_fringe() had a bug, which should now >> be fixed on Windows, too. Patch attached. > > Thanks, but is this really all that needs to be done? How will > gui_init_fringe be called in the non-Cairo builds? And what about NS? > On non-Cairo builds gui_init_finge is not called, the only call to gui_init_fringe in xterm.c is inside an #if USE_CAIRO. And on NS gui_init_fringe isn't called either. I just checked, NS builds are not affected by this bug.