endianness test in md5.c

endianness test in md5.c

[Ulrich Mueller]

src/md5.c contains the following code:

   # include <endian.h>
   # if __BYTE_ORDER == __BIG_ENDIAN
   #  define WORDS_BIG_ENDIAN 1
   # endif

I wonder, shouldn't it just use the macro defined in m/*.h instead
(at least for the case that HAVE_CONFIG_H is defined)?

Ulrich

Re: endianness test in md5.c

[Andreas Schwab]

Ulrich Mueller <ulm@gentoo.org> writes:

> src/md5.c contains the following code:
>
>    # include <endian.h>
>    # if __BYTE_ORDER == __BIG_ENDIAN
>    #  define WORDS_BIG_ENDIAN 1
>    # endif
>
> I wonder, shouldn't it just use the macro defined in m/*.h instead
> (at least for the case that HAVE_CONFIG_H is defined)?

This is only used when compiled as part of glibc.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: endianness test in md5.c

[Eli Zaretskii]

> From: Andreas Schwab <schwab@suse.de>
> Date: Sat, 18 Oct 2008 11:06:57 +0200
> Cc: emacs-devel@gnu.org
> 
> Ulrich Mueller <ulm@gentoo.org> writes:
> 
> > src/md5.c contains the following code:
> >
> >    # include <endian.h>
> >    # if __BYTE_ORDER == __BIG_ENDIAN
> >    #  define WORDS_BIG_ENDIAN 1
> >    # endif
> >
> > I wonder, shouldn't it just use the macro defined in m/*.h instead
> > (at least for the case that HAVE_CONFIG_H is defined)?
> 
> This is only used when compiled as part of glibc.

Exactly.  And md5.c is imported from glibc, so we don't want to make
local changes to it that are not necessary for Emacs, to make
importing future versions easier.