From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ulrich Mueller Newsgroups: gmane.emacs.devel Subject: Re: SuperH port Date: Wed, 8 Oct 2008 20:22:13 +0200 Message-ID: <18668.64085.372743.905358@a1ihome1.kph.uni-mainz.de> References: <18668.31387.21197.719443@a1ihome1.kph.uni-mainz.de> <200810081431.m98EVuUJ011805@mothra.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1223490253 26868 80.91.229.12 (8 Oct 2008 18:24:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 8 Oct 2008 18:24:13 +0000 (UTC) Cc: sh@gentoo.org, emacs-devel@gnu.org, emacs@gentoo.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 08 20:25:09 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Kndhz-0002mj-VW for ged-emacs-devel@m.gmane.org; Wed, 08 Oct 2008 20:24:28 +0200 Original-Received: from localhost ([127.0.0.1]:54873 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kndgv-0007eU-F4 for ged-emacs-devel@m.gmane.org; Wed, 08 Oct 2008 14:23:21 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kndg4-0007Jk-Ta for emacs-devel@gnu.org; Wed, 08 Oct 2008 14:22:28 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kndg3-0007JI-1u for emacs-devel@gnu.org; Wed, 08 Oct 2008 14:22:28 -0400 Original-Received: from [199.232.76.173] (port=33648 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kndg2-0007JC-UN for emacs-devel@gnu.org; Wed, 08 Oct 2008 14:22:26 -0400 Original-Received: from a1iwww1.kph.uni-mainz.de ([134.93.134.1]:48773) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Kndg1-0007MC-Ed for emacs-devel@gnu.org; Wed, 08 Oct 2008 14:22:26 -0400 Original-Received: from a1ihome1.kph.uni-mainz.de (a1ihome1.kph.uni-mainz.de [134.93.134.75]) by a1iwww1.kph.uni-mainz.de (8.14.0/8.13.4) with ESMTP id m98IMDEu010018; Wed, 8 Oct 2008 20:22:13 +0200 Original-Received: from a1ihome1.kph.uni-mainz.de (localhost [127.0.0.1]) by a1ihome1.kph.uni-mainz.de (8.14.0/8.14.1) with ESMTP id m98IMD9E017115; Wed, 8 Oct 2008 20:22:13 +0200 Original-Received: (from ulm@localhost) by a1ihome1.kph.uni-mainz.de (8.14.0/8.14.0/Submit) id m98IMDCm017110; Wed, 8 Oct 2008 20:22:13 +0200 In-Reply-To: <200810081431.m98EVuUJ011805@mothra.ics.uci.edu> X-Mailer: VM 8.0.2-487 under Emacs 22.2.1 (i686-pc-linux-gnu) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:104428 Archived-At: >>>>> On Wed, 8 Oct 2008, Dan Nicolaescu wrote: > Given this from your patch: >> + Status of SuperH support on NetBSD and OpenBSD is unknown. > Please do not wily nilly add them back, removing stuff is not something > we take lightly, so we should not be adding back things that are not > known to work, nor were requested by actual users. These are just alternatives in case statements (two lines). No problem to remove them, but OTOH I think they cannot do any harm. Also, support for BSD on SuperH had been added less then two years ago, so why would you expect it to be broken? Especially, since apart from configure and the machine definition, nothing else is affected. 2006-12-22 Mark Davies * configure.in: Add support for NetBSD on x86-64, hp800 and sh3el. >> + ## SuperH (little endian) Linux-based GNU system >> + sh[34]-*-linux-gnu* ) >> + machine=sh3el opsys=gnu-linux >> + ;; >> + >> + ## SuperH (big endian) Linux-based GNU system >> + sh[34]eb-*-linux-gnu* ) >> + machine=sh3eb opsys=gnu-linux >> + ;; > Were both endian versions tested? > Why have two files, only a single macro should be different between > them, and it can be conditionally defined. No other machine file does this. But maybe it is a good idea to get rid of WORDS_BIG_ENDIAN in general, given the following comment in configure.in: dnl This could be used for targets which can have both byte sexes. dnl We could presumably replace the hardwired WORDS_BIG_ENDIAN generally. dnl AC_C_BIGENDIAN > Simply adding the file back is not OK, work has been done to clean up > and simplify these files. That work would have been better invested to get rid of the antediluvian build system with its hardwired config files. And if you had done a diff to the file in the CVS attic, then you would have noticed that I already did some cleanup to bring the file in line with the changes in the other machine files. Of course it is possible that I've missed something. >> +#define LOAD_AVE_TYPE long >> +#define LOAD_AVE_CVT(x) (int) (((double) (x)) * 100.0 / FSCALE) > These are not needed for GNU/Linux, remove them. As far as I understand it, the m/*.h files are supposed to be OS independent? Concerning EXPLICIT_SIGN_EXTEND, CANNOT_DUMP, VIRT_ADDR_VARIES, HAVE_ALLOCA, and NO_REMAP, I'll remove the corresponding lines and have it tested again. However, from your rather discouraging reply I have the impression that this port is not wanted? Best regards Ulrich