all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Gemini Lasswell <gazally@runbox.com>
Cc: 22294@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#22294: Generating Edebug names for generic methods
Date: Sun, 14 May 2017 04:17:47 +0300	[thread overview]
Message-ID: <185bc21c-9730-95f5-74d6-70147d9867a1@yandex.ru> (raw)
In-Reply-To: <87wp9kwk2n.fsf@runbox.com>

On 13.05.2017 23:58, Gemini Lasswell wrote:

> It works in my testing too. Here's a revised version of the patch with
> your changes incorporated and a couple of other changes too.

Thanks! I'll push this version shortly.

> Since a
> method's argument list is supposed to be a list but not nil, I changed
> the test for a valid one from listp to consp.

Like mentioned, nil arguments list also works (in Emacs but not in 
CLOS). If people prefer this possibility is not used, though, that's 
fine by me.

> I also changed the names of method-args and edebug-match-method-args to
> cl-generic-method-args and edebug-match-cl-generic-method-args to better
> associate them with the code that uses them, and to avoid the idea that
> this might be new Edebug specification list functionality that should
> really be documented.

Sounds good.





  reply	other threads:[~2017-05-14  1:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-02 18:53 bug#22294: 25.0.50; edebug should support jumping into generic methods Dmitry Gutov
2017-03-03  2:52 ` Gemini Lasswell
2017-04-11 10:57   ` Dmitry Gutov
2017-04-26 23:12     ` bug#22294: Patch (was: bug#22294: 25.0.50; edebug should support jumping into generic methods) Gemini Lasswell
2017-05-07  2:34       ` bug#22294: Patch Dmitry Gutov
2017-05-07 20:28         ` Gemini Lasswell
2017-05-08  2:19           ` Dmitry Gutov
2017-05-10  5:07             ` bug#22294: Generating Edebug names for generic methods (was: bug#22294: Patch) Gemini Lasswell
2017-05-10 14:18               ` bug#22294: Generating Edebug names for generic methods Dmitry Gutov
2017-05-13 20:58                 ` Gemini Lasswell
2017-05-14  1:17                   ` Dmitry Gutov [this message]
2017-05-14 20:33                     ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=185bc21c-9730-95f5-74d6-70147d9867a1@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=22294@debbugs.gnu.org \
    --cc=gazally@runbox.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.