bug#2534: NS: clipboard-kill-ring-save and clipboard-yank etc. not available

bug#2534: NS: clipboard-kill-ring-save and clipboard-yank etc. not available

[David Reitter]

[-- Attachment #1: Type: text/plain, Size: 1244 bytes --]

A number of functions such as `clipboard-kill-ring-save' are not  
available in the NS port because term/ns-win.el unbinds them.
It took me a long time to figure out, because they are pre-loaded in  
menu-bar.el and present in `load-history'.

In the interest of compatibility with existing Emacs 22 code, and also  
with Emacs 23 code written on other platforms, these functions should  
exist and do what they're documented to do.

Note that commands like `ns-copy-including-secondary' are bound to  
menu bar items and to shortcuts such as Command-C (when CUA mode is  
off), but they are not documented.  I would happily write some  
docstrings, but it isn't clear to me why one would always want to set  
the secondary "cut buffer" in this situation.



term/ns-win.el:

;; Must come after keybindings.

(fmakunbound 'clipboard-yank)
(fmakunbound 'clipboard-kill-ring-save)
(fmakunbound 'clipboard-kill-region)
(fmakunbound 'menu-bar-enable-clipboard)

...

(defun ns-copy-including-secondary ()
   (interactive)
   (call-interactively 'kill-ring-save)
   (ns-store-cut-buffer-internal 'SECONDARY
				(buffer-substring (point) (mark t))))
(defun ns-paste-secondary ()
   (interactive)
   (insert (ns-get-cut-buffer-internal 'SECONDARY)))


[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 2193 bytes --]

bug#2534: marked as done (NS: clipboard-kill-ring-save and clipboard-yank etc. not available)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 870 bytes --]


Your message dated Mon, 4 May 2009 12:27:46 -0400
with message-id <1BFB2DB5-04E2-4EF2-9576-A0016127D9A3@cmu.edu>
and subject line fixed
has caused the Emacs bug report #2534,
regarding NS: clipboard-kill-ring-save and clipboard-yank etc. not available
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
2534: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=2534
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 7718 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 1244 bytes --]

A number of functions such as `clipboard-kill-ring-save' are not  
available in the NS port because term/ns-win.el unbinds them.
It took me a long time to figure out, because they are pre-loaded in  
menu-bar.el and present in `load-history'.

In the interest of compatibility with existing Emacs 22 code, and also  
with Emacs 23 code written on other platforms, these functions should  
exist and do what they're documented to do.

Note that commands like `ns-copy-including-secondary' are bound to  
menu bar items and to shortcuts such as Command-C (when CUA mode is  
off), but they are not documented.  I would happily write some  
docstrings, but it isn't clear to me why one would always want to set  
the secondary "cut buffer" in this situation.



term/ns-win.el:

;; Must come after keybindings.

(fmakunbound 'clipboard-yank)
(fmakunbound 'clipboard-kill-ring-save)
(fmakunbound 'clipboard-kill-region)
(fmakunbound 'menu-bar-enable-clipboard)

...

(defun ns-copy-including-secondary ()
   (interactive)
   (call-interactively 'kill-ring-save)
   (ns-store-cut-buffer-internal 'SECONDARY
				(buffer-substring (point) (mark t))))
(defun ns-paste-secondary ()
   (interactive)
   (insert (ns-get-cut-buffer-internal 'SECONDARY)))


[-- Attachment #2.1.2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 2193 bytes --]

[-- Attachment #3: Type: message/rfc822, Size: 1944 bytes --]

From: David Reitter <reitter@cmu.edu>
To: 2534-done@emacsbugs.donarmstrong.com
Subject: fixed
Date: Mon, 4 May 2009 12:27:46 -0400
Message-ID: <1BFB2DB5-04E2-4EF2-9576-A0016127D9A3@cmu.edu>

fixed by removing the apparently obsolete code in term/ns-win.el that  
deletes these functions

bug#2534: NS: clipboard-kill-ring-save and clipboard-yank etc. not available

[Adrian Robert]

> A number of functions such as `clipboard-kill-ring-save' are not
> available in the NS port because term/ns-win.el unbinds them.
> It took me a long time to figure out, because they are pre-loaded in
> menu-bar.el and present in `load-history'.

To to you the truth I'm not sure ATM why these are unbound.  You  
could try commenting those lines out and seeing if anything bad happens.


> Note that commands like `ns-copy-including-secondary' are bound to
> menu bar items and to shortcuts such as Command-C (when CUA mode is
> off), but they are not documented.  I would happily write some
> docstrings, but it isn't clear to me why one would always want to set
> the secondary "cut buffer" in this situation.

These are mainly for running under GNUstep in X windows, where the  
semantics of the two selection buffers have been confused for a long  
time, so it made sense just to throw things into both.  These  
commands are bound to keys and I believe discussed in the manual.  If  
you think they could be documented better, or should be enabled only  
under GNUstep, please go ahead with such changes.