From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#26973: 26.0.50; sleep-for behavior changes with global-auto-revert-mode enabled Date: Sat, 27 May 2017 11:19:48 -0700 Organization: UCLA Computer Science Department Message-ID: <1846cfcb-1897-e3d8-76fe-83be1c076c75@cs.ucla.edu> References: <52366f47-5bf1-8eaa-f605-44d0def010aa@cs.ucla.edu> <87tw46w92f.fsf@luca> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1495909215 25485 195.159.176.226 (27 May 2017 18:20:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 27 May 2017 18:20:15 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 Cc: 26973-done@debbugs.gnu.org, Michael Albinus , Dmitry Gutov To: Andreas Politz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 27 20:20:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dEgJu-0006VI-FM for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 May 2017 20:20:10 +0200 Original-Received: from localhost ([::1]:41671 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dEgJz-00037T-UK for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 May 2017 14:20:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dEgJp-0002y7-T0 for bug-gnu-emacs@gnu.org; Sat, 27 May 2017 14:20:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dEgJm-0006Lc-Mh for bug-gnu-emacs@gnu.org; Sat, 27 May 2017 14:20:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38321) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dEgJm-0006LV-Ib for bug-gnu-emacs@gnu.org; Sat, 27 May 2017 14:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dEgJm-0005E8-3T for bug-gnu-emacs@gnu.org; Sat, 27 May 2017 14:20:02 -0400 Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 May 2017 18:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 26973 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 26973@debbugs.gnu.org, eggert@cs.ucla.edu, dgutov@yandex.ru Original-Received: via spool by 26973-done@debbugs.gnu.org id=D26973.149590919720074 (code D ref 26973); Sat, 27 May 2017 18:20:01 +0000 Original-Received: (at 26973-done) by debbugs.gnu.org; 27 May 2017 18:19:57 +0000 Original-Received: from localhost ([127.0.0.1]:40998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dEgJh-0005Dh-9L for submit@debbugs.gnu.org; Sat, 27 May 2017 14:19:57 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:45774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dEgJf-0005DU-9B for 26973-done@debbugs.gnu.org; Sat, 27 May 2017 14:19:56 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 4D33B16007B; Sat, 27 May 2017 11:19:49 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id uDGm9nQvQOnH; Sat, 27 May 2017 11:19:48 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 918E71600C6; Sat, 27 May 2017 11:19:48 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id NrBjMbF1jAei; Sat, 27 May 2017 11:19:48 -0700 (PDT) Original-Received: from [192.168.1.9] (unknown [47.153.188.248]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 716B316007B; Sat, 27 May 2017 11:19:48 -0700 (PDT) In-Reply-To: <87tw46w92f.fsf@luca> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132931 Archived-At: Andreas Politz wrote: > I think your patches are against an older revision. OK, I rebased the patches to master and installed them there (after adjusting to the comments below) so you shouldn't have to worry about version mismatch. >> [...] a later call to inotify-add-watch that lacks IN_OPEN will >> disable an already-existing watch that specifies IN_OPEN, right? [...] > > I don't think so. It means that no one can watch for open/close/access > events Oh, right. I fixed the commit message accordingly. >> [...] The second patch restores onlydir (it appears to have been >> removed by mistake). > > See above, I guess. Yeah, I checked the GNU/Linux source code, and it is a flag that affects only the inotify_add_watch call itself, not the watch descriptor, so we don't need to worry about it colliding with other watches. >> The third patch uses IN_MASK_ADD instead of a promiscuous mask. > > We could do that. Thanks, it's now done as part of the installed patches. I verified that the originally-reported bug is still fixed in master, and am marking the bug as done.