From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ulrich Mueller Newsgroups: gmane.emacs.devel Subject: vc.el and CSSC Date: Sat, 19 Apr 2008 18:27:34 +0200 Message-ID: <18442.7542.570702.854133@a1ihome1.kph.uni-mainz.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1208629093 26757 80.91.229.12 (19 Apr 2008 18:18:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 19 Apr 2008 18:18:13 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 19 20:18:48 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JnFvU-0007bN-Mb for ged-emacs-devel@m.gmane.org; Sat, 19 Apr 2008 18:28:32 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JnFup-0007Fx-L0 for ged-emacs-devel@m.gmane.org; Sat, 19 Apr 2008 12:27:51 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JnFul-0007Fs-TA for emacs-devel@gnu.org; Sat, 19 Apr 2008 12:27:47 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JnFui-0007FM-UY for emacs-devel@gnu.org; Sat, 19 Apr 2008 12:27:46 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JnFui-0007FE-OP for emacs-devel@gnu.org; Sat, 19 Apr 2008 12:27:44 -0400 Original-Received: from a1iwww1.kph.uni-mainz.de ([134.93.134.1]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JnFuj-0008H5-4E for emacs-devel@gnu.org; Sat, 19 Apr 2008 12:27:45 -0400 Original-Received: from a1ihome1.kph.uni-mainz.de (a1ihome1.kph.uni-mainz.de [134.93.134.75]) by a1iwww1.kph.uni-mainz.de (8.14.2/8.13.4) with ESMTP id m3JGRZ1c000399 for ; Sat, 19 Apr 2008 18:27:36 +0200 Original-Received: from a1ihome1.kph.uni-mainz.de (localhost [127.0.0.1]) by a1ihome1.kph.uni-mainz.de (8.14.2/8.14.1) with ESMTP id m3JGRZWn029003; Sat, 19 Apr 2008 18:27:35 +0200 Original-Received: (from ulm@localhost) by a1ihome1.kph.uni-mainz.de (8.14.2/8.14.2/Submit) id m3JGRZeY028998; Sat, 19 Apr 2008 18:27:35 +0200 X-Mailer: VM 8.0.9 under Emacs 22.1.1 (i686-pc-linux-gnu) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:95464 Archived-At: Hi, while applying and testing the recent security fix for lib-src/vcdiff (CVE-2008-1694), I've noticed that vc does not work with GNU CSSC. The vcdiff script doesn't find the "get" command which CSSC installs in /usr/libexec/cssc/: /usr/libexec/emacs/22.2/i686-pc-linux-gnu/vcdiff: line 88: get: command not found Also, commands like vc-sccs-checkout don't work because they don't find "get" in PATH. The patch included below (for CVS trunk) should fix it. However, I did only some basic testing (checkout, checkin, diff). Ulrich --- lib-src/vcdiff 19 Apr 2008 10:11:34 +0200 1.17 +++ lib-src/vcdiff 19 Apr 2008 17:53:59 +0200 @@ -27,7 +27,8 @@ DIFF="diff" usage="$0: Usage: vcdiff [--brief] [-q] [-r] [-r] [diffopts] sccsfile..." -PATH=$PATH:/usr/ccs/bin:/usr/sccs:/usr/xpg4/bin # common SCCS hangouts +# common SCCS hangouts +PATH=$PATH:/usr/libexec/cssc:/usr/ccs/bin:/usr/sccs:/usr/xpg4/bin echo="echo" sid1= sid2= --- lisp/vc-hooks.el 19 Apr 2008 10:11:35 +0200 1.238 +++ lisp/vc-hooks.el 19 Apr 2008 17:55:59 +0200 @@ -85,9 +85,11 @@ :group 'vc) (defcustom vc-path - (if (file-directory-p "/usr/sccs") - '("/usr/sccs") - nil) + (append + (if (file-directory-p "/usr/libexec/cssc") + '("/usr/libexec/cssc")) + (if (file-directory-p "/usr/sccs") + '("/usr/sccs"))) "List of extra directories to search for version control commands." :type '(repeat directory) :group 'vc)