From: Paul Eggert <eggert@cs.ucla.edu>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: Richard Copley <rcopley@gmail.com>,
martin rudalics <rudalics@gmx.at>,
emacs-devel <emacs-devel@gnu.org>
Subject: Re: Building master fails on Windows 10 when testing etc/NEWS file
Date: Wed, 18 Sep 2019 05:23:20 -0700 [thread overview]
Message-ID: <1840bbb1-50de-870d-99d9-b4340e3c3b92@cs.ucla.edu> (raw)
In-Reply-To: <CAAeL0SRyLNeM=tHSgadYf6S-7X+XhrY5REK-KZFMoncM89_GoQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 724 bytes --]
On 9/18/19 4:36 AM, Juanma Barranquero wrote:
> ELC ../lisp/replace.elc
> Can't find D:\Devel\emacs\repo\trunk\src\bootstrap-emacs.exe to refresh
> preloaded Lisp files
Thanks, I installed the attached to try to fix that.
> Loading leim/leim-list.el (source)...
> Waiting for git...
> Error running git rev-parse: (file-error "Searching for program"
> "Permission denied" "git")
> Waiting for git...
> Error running git rev-parse --abbrev-ref: (file-error "Searching for
> program" "Permission denied" "git")
Is there a 'git' program in your PATH? What's the output of the following shell
script (or equivalent) on your host?
IFS=':'
for dir in $PATH; do
ls -ld "$dir" "$dir/git"
echo =============
done
[-- Attachment #2: 0001-Be-less-picky-about-EACCES-in-file-test-predicates.patch --]
[-- Type: text/x-patch, Size: 1907 bytes --]
From efa4edfadb3d8ac051ac21ccb4238f3eadb091dd Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Wed, 18 Sep 2019 04:21:19 -0700
Subject: [PATCH] Be less picky about EACCES in file test predicates
Problem reported by Tino Calancha (Bug#37445) and others.
* src/fileio.c (PICKY_EACCES): New constant, false by default.
(file_test_errno): Ignore EACCES if not picky.
(check_file_access): Investigate EACCES problems further
if picky.
---
src/fileio.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/src/fileio.c b/src/fileio.c
index 0977516f01..58bc6b7ee8 100644
--- a/src/fileio.c
+++ b/src/fileio.c
@@ -253,9 +253,23 @@ file_attribute_errno (Lisp_Object file, int err)
return file_metadata_errno ("Getting attributes", file, err);
}
+/* In theory, EACCES errors for predicates like file-readable-p should
+ be checked further because they may be problems with an ancestor
+ directory instead of with the file itself, which means that we
+ don't have reliable info about the requested file. In practice,
+ though, such errors are common enough that signaling them can be
+ annoying even if the errors are real (e.g., Bug#37445). So return
+ nil for EACCES unless compiling with -DPICKY_EACCES, which is off
+ by default. */
+#ifndef PICKY_EACCES
+enum { PICKY_EACCES = false };
+#endif
+
static Lisp_Object
file_test_errno (Lisp_Object file, int err)
{
+ if (!PICKY_EACCES && err == EACCES)
+ return Qnil;
return file_metadata_errno ("Testing file", file, err);
}
@@ -2745,7 +2759,7 @@ check_file_access (Lisp_Object file, Lisp_Object operation, int amode)
return Qt;
int err = errno;
if (err == EROFS || err == ETXTBSY
- || (err == EACCES && amode != F_OK
+ || (PICKY_EACCES && err == EACCES && amode != F_OK
&& file_access_p (encoded_file, F_OK)))
{
errno = err;
--
2.17.1
next prev parent reply other threads:[~2019-09-18 12:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 7:45 Building master fails on Windows 10 when testing etc/NEWS file martin rudalics
2019-09-18 10:08 ` Paul Eggert
2019-09-18 10:33 ` Richard Copley
2019-09-18 11:26 ` Paul Eggert
2019-09-18 11:36 ` Juanma Barranquero
2019-09-18 12:23 ` Paul Eggert [this message]
2019-09-18 12:31 ` Juanma Barranquero
2019-09-18 12:44 ` Eli Zaretskii
2019-09-18 14:27 ` Richard Copley
2019-09-18 15:01 ` Juanma Barranquero
2019-09-18 15:45 ` Eli Zaretskii
2019-09-18 17:00 ` Richard Copley
2019-09-18 17:23 ` Eli Zaretskii
2019-09-18 18:33 ` Eli Zaretskii
2019-09-18 18:35 ` Richard Copley
2019-09-18 18:49 ` Eli Zaretskii
2019-09-18 18:54 ` Richard Copley
2019-09-18 18:47 ` Eli Zaretskii
2019-09-18 20:16 ` Paul Eggert
2019-09-19 8:18 ` martin rudalics
2019-09-19 9:53 ` Juanma Barranquero
2019-09-19 9:59 ` Juanma Barranquero
2019-09-18 15:05 ` Eli Zaretskii
2019-09-18 12:33 ` Eli Zaretskii
2019-09-18 12:37 ` Eli Zaretskii
2019-09-19 7:27 ` Paul Eggert
2019-09-18 10:35 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1840bbb1-50de-870d-99d9-b4340e3c3b92@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
--cc=rcopley@gmail.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.