[BUG] menubar on a console (Emacs 23)

[BUG] menubar on a console (Emacs 23)

[Nick Roberts]

The visibilty of the menubar only extends as far as the last menu item on
a console with Emacs 23.0.60.  Previously (and with EMACS_22_BASE) it would
stretch across the entire screen.

-- 
Nick                                           http://www.inet.net.nz/~nickrob

Re: [BUG] menubar on a console (Emacs 23)

[Romain Francoise]

Nick Roberts <nickrob@snap.net.nz> writes:

> The visibilty of the menubar only extends as far as the last menu
> item on a console with Emacs 23.0.60.  Previously (and with
> EMACS_22_BASE) it would stretch across the entire screen.

Yes, it's caused by the following changes; Kim is looking into it.

2008-02-27  Kim F. Storm  <storm@cua.dk>

	* lisp.h (GLYPH): Change type from int to struct with separate char
	and face_id members.
	(GLYPH_MASK_FACE, GLYPH_MASK_CHAR): Delete macros.
	(GLYPH_CHAR, GLYPH_FACE): Remove slow versions with frame arg.
	(FAST_GLYPH_CHAR, FAST_GLYPH_FACE): Rename macros to ...
	(GLYPH_CHAR, GLYPH_FACE): ... these.  Change users.
	(FAST_MAKE_GLYPH, MAKE_GLYPH): Remove.  Rewrite users to use ...
	(SET_GLYPH, SET_GLYPH_CHAR, SET_GLYPH_FACE): ... these macros instead.
	(GLYPH_CODE_CHAR, GLYPH_CODE_FACE, GLYPH_CODE_P)
	(GLYPH_CODE_CHAR_VALID_P, SET_GLYPH_FROM_GLYPH_CODE): New macros to
	handle new Lisp glyph code encoding, either an integer or a cons.

	* disptab.h (GLYPH_SIMPLE_P): Rewrite.
	(GLYPH_ALIAS): Delete.
	(GLYPH_ALIAS_P, GLYPH_FOLLOW_ALIASES): Rewrite.
	(GLYPH_LENGTH, GLYPH_STRING): Use GLYPH_CHAR.
	(GLYPH_FROM_CHAR): Replace macro by ...
	(SET_GLYPH_FROM_CHAR): ... this macro.  Change users.

	* dispextern.h (CHAR_GLYPH_SPACE_P): Simplify.
	(GLYPH_FROM_CHAR_GLYPH): Replace macro by ...
	(SET_GLYPH_FROM_CHAR_GLYPH): ... this macro.  Change users.
	(GLYPH_INVALID_P): New macro.
	(spec_glyph_lookup_face): Update prototype.

	* dispnew.c (line_draw_cost): Adapt to new glyph type.
	(build_frame_matrix_from_leaf_window): Adapt to new glyph type and
	new glyph code encoding.
	(spec_glyph_lookup_face): No return value; update passed glyph instead.
	(init_display): Use SET_CHAR_GLYPH to initialize space_glyph.

	* xdisp.c (get_next_display_element, next_element_from_display_vector):
	Adapt to new glyph type and new glyph code encoding.

	* term.c (encode_terminal_code, produce_special_glyphs): Likewise.

	* indent.c (current_column, current_column_1, Fmove_to_column)
	(compute_motion): Adapt to new glyph code encoding.

	* msdos.c (IT_write_glyphs): Adapt to new glyph type.

Re: [BUG] menubar on a console (Emacs 23)

[Kim F. Storm]

Nick Roberts <nickrob@snap.net.nz> writes:

> The visibilty of the menubar only extends as far as the last menu item on
> a console with Emacs 23.0.60.  Previously (and with EMACS_22_BASE) it would
> stretch across the entire screen.

I just installed a fix.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: [BUG] menubar on a console (Emacs 23)

[Nick Roberts]

 > > The visibilty of the menubar only extends as far as the last menu item on
 > > a console with Emacs 23.0.60.  Previously (and with EMACS_22_BASE) it would
 > > stretch across the entire screen.
 > 
 > I just installed a fix.

Welcome back, and thanks.

I don't suppose you would know how to fix mouse clicks on the menubar?

I put this entry in FOR-RELEASE:

** Mouse clicks on the menubar don't currently work with a console
Following the direct use of Gpm, the menubar now needs to be
considered a special part of the screen in Emacs on a console.
http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00277.html

I broke this functionality (it wasn't available in Emacs before 22.1) in the
trunk when I added mouse highlighting and made mouse clicks work at the C
level.

-- 
Nick                                           http://www.inet.net.nz/~nickrob