From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nick Roberts Newsgroups: gmane.emacs.devel Subject: Re: vc-set-mode-line-busy-indicator Date: Tue, 26 Feb 2008 09:25:31 +1300 Message-ID: <18371.9275.720477.806834@kahikatea.snap.net.nz> References: <18370.47294.641890.556694@kahikatea.snap.net.nz> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1203971158 13575 80.91.229.12 (25 Feb 2008 20:25:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 25 Feb 2008 20:25:58 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 25 21:26:20 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JTjtz-0000S8-Ko for ged-emacs-devel@m.gmane.org; Mon, 25 Feb 2008 21:26:20 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JTjtT-0003KA-Od for ged-emacs-devel@m.gmane.org; Mon, 25 Feb 2008 15:25:47 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JTjtO-0003HX-0S for emacs-devel@gnu.org; Mon, 25 Feb 2008 15:25:42 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JTjtK-0003DH-BV for emacs-devel@gnu.org; Mon, 25 Feb 2008 15:25:41 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JTjtJ-0003D0-VR for emacs-devel@gnu.org; Mon, 25 Feb 2008 15:25:38 -0500 Original-Received: from viper.snap.net.nz ([202.37.101.8]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JTjtJ-0001Nv-LZ for emacs-devel@gnu.org; Mon, 25 Feb 2008 15:25:37 -0500 Original-Received: from kahikatea.snap.net.nz (25.30.255.123.static.snap.net.nz [123.255.30.25]) by viper.snap.net.nz (Postfix) with ESMTP id 219543D9F3E for ; Tue, 26 Feb 2008 09:25:35 +1300 (NZDT) Original-Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 3D1C38FC6D; Tue, 26 Feb 2008 09:25:33 +1300 (NZDT) In-Reply-To: <18370.47294.641890.556694@kahikatea.snap.net.nz> X-Mailer: VM 7.19 under Emacs 23.0.60.22 X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:90430 Archived-At: Nick Roberts writes: > > The problem with this message is that it is so long that the bit after > ("from filename") doesn't fit in 80 columns. Also a warning-face isn't > really needed because it doesn't provide a wake up call: the user has just > entered a command, e.g, vc-diff or vc-print-log, so presumably he's already > looking for the output buffer. > > I've used the same style as I've used for the GUD buffer. If text in the > mode-line is going to be increasingly fontified, it might be a good idea to > have some consistency. I forgot to ask: Shall I apply this patch? > -- > Nick http://www.inet.net.nz/~nickrob > > > *** vc.el.~1.541.~ 2008-02-24 08:24:18.000000000 +1300 > --- vc.el 2008-02-26 01:29:24.000000000 +1300 > *************** BUF defaults to \"*vc*\", can be a strin > *** 1064,1077 **** > > (defun vc-set-mode-line-busy-indicator () > (setq mode-line-process > ! ;; Deliberate overstatement, but power law respected. > ! ;; (The message is ephemeral, so we make it loud.) --ttn > ! (propertize " (incomplete/in progress)" > ! 'face (if (featurep 'compile) > ! ;; ttn's preferred loudness > ! 'compilation-warning > ! ;; suitably available fallback > ! font-lock-warning-face) > 'help-echo > "A VC command is in progress in this buffer"))) > > --- 1064,1071 ---- > > (defun vc-set-mode-line-busy-indicator () > (setq mode-line-process > ! (propertize " [waiting...]" > ! 'face 'font-lock-variable-name-face > 'help-echo > "A VC command is in progress in this buffer"))) >