From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nick Roberts Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: [22.1.90]: Barf in left margin in *stack frames of emacs* Date: Thu, 21 Feb 2008 00:51:08 +1300 Message-ID: <18364.5164.553771.796947@kahikatea.snap.net.nz> References: <6EE216E1AA959543A555C60FF34FB7670305BEEE@maileube01.misys.global.ad> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1203508311 23151 80.91.229.12 (20 Feb 2008 11:51:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 20 Feb 2008 11:51:51 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org To: "Marshall, Simon" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 20 12:52:13 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JRnUb-0004pZ-LC for ged-emacs-devel@m.gmane.org; Wed, 20 Feb 2008 12:52:05 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JRnU6-0003CE-Pd for ged-emacs-devel@m.gmane.org; Wed, 20 Feb 2008 06:51:34 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JRnU3-0003Bz-65 for emacs-devel@gnu.org; Wed, 20 Feb 2008 06:51:31 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JRnTy-0003B4-Ge for emacs-devel@gnu.org; Wed, 20 Feb 2008 06:51:30 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JRnTy-0003B0-D8 for emacs-devel@gnu.org; Wed, 20 Feb 2008 06:51:26 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JRnTy-0000Wx-Au for emacs-devel@gnu.org; Wed, 20 Feb 2008 06:51:26 -0500 Original-Received: from mx10.gnu.org ([199.232.76.166]) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1JRnTx-0006zT-Om for emacs-pretest-bug@gnu.org; Wed, 20 Feb 2008 06:51:25 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1JRnTv-0000Vk-08 for emacs-pretest-bug@gnu.org; Wed, 20 Feb 2008 06:51:26 -0500 Original-Received: from viper.snap.net.nz ([202.37.101.8]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JRnTu-0000Ty-8y for emacs-pretest-bug@gnu.org; Wed, 20 Feb 2008 06:51:22 -0500 Original-Received: from kahikatea.snap.net.nz (237.31.255.123.static.snap.net.nz [123.255.31.237]) by viper.snap.net.nz (Postfix) with ESMTP id BCFBE3D9F21; Thu, 21 Feb 2008 00:51:14 +1300 (NZDT) Original-Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 43B928FC6D; Thu, 21 Feb 2008 00:51:09 +1300 (NZDT) In-Reply-To: <6EE216E1AA959543A555C60FF34FB7670305BEEE@maileube01.misys.global.ad> X-Mailer: VM 7.19 under Emacs 22.1.90.4 X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:89677 gmane.emacs.pretest.bugs:21248 Archived-At: > In *stack frames of emacs*, I can left-click in the right margin to > horizontally scroll the window. Gud is good. However, when I > left-click in the left margin to horizontally scroll back, I get an > error. > > emacs -Q > M-x gdb RET RET ; for me, running gdb on emacs > In *gud-emacs*, put a breakpoint somewhere that will get hit and "r -Q" > > When the breakpoint hits, select "Options | Enter Debugger on Error" and > "Gud | GDB-Frames | Stack" to popup the *stack frames of emacs* frame. > Left-click in the right margin to horizontally scroll the *stack frames > of emacs* window, then left-click in the left margin to scroll back. I > get: > > Debugger entered--Lisp error: (wrong-type-argument stringp nil) > file-name-nondirectory(nil) > gud-format-command("break %f:%l" nil) > gud-call("break %f:%l" nil) > gud-break(nil) > gdb-mouse-set-clear-breakpoint((mouse-1 (# of emacs*> left-fringe (2 . 32) 178127836 nil 250 (0 . 2) nil (2 . 6) (8 > . 13)))) > call-interactively(gdb-mouse-set-clear-breakpoint) Good catch. Does the patch below (on EMACS_22_BASE), fix it? -- Nick http://www.inet.net.nz/~nickrob *** gdb-ui.el 19 Feb 2008 21:55:10 +1300 1.206.2.19 --- gdb-ui.el 21 Feb 2008 00:47:52 +1300 *************** static char *magick[] = { *** 1972,1986 **** (interactive "e") (mouse-minibuffer-check event) (let ((posn (event-end event))) ! (if (numberp (posn-point posn)) ! (with-selected-window (posn-window posn) ! (save-excursion ! (goto-char (posn-point posn)) ! (if (or (posn-object posn) ! (eq (car (fringe-bitmaps-at-pos (posn-point posn))) ! 'breakpoint)) ! (gud-remove nil) ! (gud-break nil))))))) (defun gdb-mouse-toggle-breakpoint-margin (event) "Enable/disable breakpoint in left margin with mouse click." --- 1972,1988 ---- (interactive "e") (mouse-minibuffer-check event) (let ((posn (event-end event))) ! (if (buffer-file-name) ! (if (numberp (posn-point posn)) ! (with-selected-window (posn-window posn) ! (save-excursion ! (goto-char (posn-point posn)) ! (if (or (posn-object posn) ! (eq (car (fringe-bitmaps-at-pos (posn-point posn))) ! 'breakpoint)) ! (gud-remove nil) ! (gud-break nil))))) ! (posn-set-point posn)))) (defun gdb-mouse-toggle-breakpoint-margin (event) "Enable/disable breakpoint in left margin with mouse click."